Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend scheduler interface for Multitenancy #3014

Merged
merged 5 commits into from
Sep 16, 2024

Conversation

noCharger
Copy link
Collaborator

@noCharger noCharger commented Sep 12, 2024

Description

Extend unscheduleJob and removeJob interface by adding AsyncQueryRequestContext instead of only jobId for Multitenancy use case. For example in async-query-core it can use composite key of jobId, accountId and data source name. The latters can be fetched from the context

Also fixed CI ref https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

Check List

  • New functionality includes testing.
  • Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@noCharger noCharger self-assigned this Sep 12, 2024
Signed-off-by: Louis Chu <[email protected]>
@noCharger noCharger force-pushed the update-scheduler-interface branch from 5be3eae to a37fc16 Compare September 12, 2024 22:21
Signed-off-by: Louis Chu <[email protected]>
@noCharger noCharger force-pushed the update-scheduler-interface branch from ac87b5d to ab4a148 Compare September 12, 2024 23:38
@noCharger noCharger requested a review from ykmr1224 September 12, 2024 23:43
@noCharger noCharger force-pushed the update-scheduler-interface branch from 1b65376 to 500f607 Compare September 13, 2024 19:07
ykmr1224
ykmr1224 previously approved these changes Sep 13, 2024
Signed-off-by: Louis Chu <[email protected]>
Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@penghuo penghuo merged commit 37188bd into opensearch-project:main Sep 16, 2024
13 of 14 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-3014-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 37188bdd5154f9a67043dcaa74ddc5587dd52858
# Push it to GitHub
git push --set-upstream origin backport/backport-3014-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-3014-to-2.x.

noCharger added a commit to noCharger/sql that referenced this pull request Sep 16, 2024
penghuo pushed a commit that referenced this pull request Sep 17, 2024
Signed-off-by: Louis Chu <[email protected]>
(cherry picked from commit 37188bd)
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.17
# Create a new branch
git switch --create backport/backport-3014-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 37188bdd5154f9a67043dcaa74ddc5587dd52858
# Push it to GitHub
git push --set-upstream origin backport/backport-3014-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-3014-to-2.17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants