-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend scheduler interface for Multitenancy #3014
Extend scheduler interface for Multitenancy #3014
Conversation
Signed-off-by: Louis Chu <[email protected]>
2bb11cd
to
7496a83
Compare
f303246
to
5be3eae
Compare
Signed-off-by: Louis Chu <[email protected]>
5be3eae
to
a37fc16
Compare
async-query-core/src/main/java/org/opensearch/sql/spark/flint/operation/FlintIndexOpAlter.java
Outdated
Show resolved
Hide resolved
async-query-core/src/main/java/org/opensearch/sql/spark/scheduler/AsyncQueryScheduler.java
Outdated
Show resolved
Hide resolved
async-query-core/src/main/java/org/opensearch/sql/spark/scheduler/AsyncQueryScheduler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Louis Chu <[email protected]>
ac87b5d
to
ab4a148
Compare
Signed-off-by: Louis Chu <[email protected]>
1b65376
to
500f607
Compare
Signed-off-by: Louis Chu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx!
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-3014-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 37188bdd5154f9a67043dcaa74ddc5587dd52858
# Push it to GitHub
git push --set-upstream origin backport/backport-3014-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.x Then, create a pull request where the |
Signed-off-by: Louis Chu <[email protected]> (cherry picked from commit 37188bd)
Signed-off-by: Louis Chu <[email protected]> (cherry picked from commit 37188bd)
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.17
# Create a new branch
git switch --create backport/backport-3014-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 37188bdd5154f9a67043dcaa74ddc5587dd52858
# Push it to GitHub
git push --set-upstream origin backport/backport-3014-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.17 Then, create a pull request where the |
Description
Extend
unscheduleJob
andremoveJob
interface by addingAsyncQueryRequestContext
instead of onlyjobId
for Multitenancy use case. For example in async-query-core it can use composite key of jobId, accountId and data source name. The latters can be fetched from the contextAlso fixed CI ref https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.