Populate indexName for BatchQuery #2956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoyuki Morita <[email protected]>
ykmr1224
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG and
LantaoJin
as code owners
ykmr1224
added
bug
|
How are we executing create manual indices earlier? |
vmmusings
reviewed
Sep 4, 2024
| @@ -106,6 +106,13 @@ public DispatchQueryResponse submit( | |||
| .resultIndex(dataSourceMetadata.getResultIndex()) | |||
| .datasourceName(dataSourceMetadata.getName()) | |||
| .jobType(JobType.INTERACTIVE) | |||
| .indexName(getIndexName(context)) | |||
There was a problem hiding this comment.
As mentioned below, we can't have name in all kinds of flint index queries? What is the indexName used for?
There was a problem hiding this comment.
DQS uses index name to populate their database to find the query where the index is created. For other query, it would become null, and that should be fine.
It used to be handled by interactive job. It did not populate indexName as well. |
Signed-off-by: Tomoyuki MORITA <[email protected]>
Signed-off-by: Tomoyuki Morita <[email protected]>
vmmusings
approved these changes
Sep 6, 2024
seankao-az
approved these changes
Sep 6, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 6, 2024
* Populate indexName for BatchQuery Signed-off-by: Tomoyuki Morita <[email protected]> * Fix test failure due to rebase Signed-off-by: Tomoyuki Morita <[email protected]> --------- Signed-off-by: Tomoyuki Morita <[email protected]> Signed-off-by: Tomoyuki MORITA <[email protected]> (cherry picked from commit b76aa65) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ykmr1224
pushed a commit
that referenced
this pull request
Sep 9, 2024
* Populate indexName for BatchQuery * Fix test failure due to rebase --------- (cherry picked from commit b76aa65) Signed-off-by: Tomoyuki Morita <[email protected]> Signed-off-by: Tomoyuki MORITA <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
n/a
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.