Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yaml errors causing checks not to be run #2820

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

derek-ho
Copy link
Collaborator

@derek-ho derek-ho commented Jul 11, 2024

Description

Due to #2815, some duplicate env variables were added, causing some yaml to be invalid and checks not to be run. This PR removes duplicates so that the actions run as expected.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@derek-ho
Copy link
Collaborator Author

@penghuo @vamsi-amazon can I get one more approval please?

Copy link
Collaborator

@ykmr1224 ykmr1224 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ykmr1224 ykmr1224 added bug Something isn't working backport 2.x labels Jul 12, 2024
@ykmr1224 ykmr1224 merged commit eb5c824 into opensearch-project:main Jul 12, 2024
14 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 12, 2024
Signed-off-by: Derek Ho <[email protected]>
(cherry picked from commit eb5c824)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ykmr1224 pushed a commit that referenced this pull request Jul 12, 2024
(cherry picked from commit eb5c824)

Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
manasvinibs pushed a commit to manasvinibs/sql that referenced this pull request Aug 14, 2024
jzonthemtn pushed a commit to jzonthemtn/sql that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants