Eliminate dependency from async-query-core to legacy #2786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoyuki Morita <[email protected]>
ykmr1224
added
backport 2.x
maintenance
ykmr1224
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2786 +/- ##
============================================
+ Coverage 94.18% 94.22% +0.04%
- Complexity 5025 5026 +1
============================================
Files 498 499 +1
Lines 14350 14350
Branches 942 942
============================================
+ Hits 13515 13522 +7
+ Misses 792 787 -5
+ Partials 43 41 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
...rc/main/java/org/opensearch/sql/spark/transport/format/CreateAsyncQueryRequestConverter.java
Show resolved
Hide resolved
vamsimanohar
approved these changes
Jun 28, 2024
rupal-bq
approved these changes
Jun 28, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 28, 2024
Signed-off-by: Tomoyuki Morita <[email protected]> (cherry picked from commit 00f82f5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ykmr1224
pushed a commit
that referenced
this pull request
Jul 11, 2024
(cherry picked from commit 00f82f5) Signed-off-by: Tomoyuki Morita <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jzonthemtn
pushed a commit
to jzonthemtn/sql
that referenced
this pull request
Aug 28, 2024
…ect#2786) Signed-off-by: Tomoyuki Morita <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
n/a
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.