Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract FlintIndex client #2755

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

ykmr1224
Copy link
Collaborator

Description

  • Abstract FlintIndex client to reduce the dependency from async-query-core to legacy

Issues Resolved

n/a

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • [n/a] New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tomoyuki Morita <[email protected]>
vamsimanohar
vamsimanohar previously approved these changes Jun 21, 2024
Signed-off-by: Tomoyuki Morita <[email protected]>
Signed-off-by: Tomoyuki Morita <[email protected]>
@ykmr1224 ykmr1224 merged commit b2403ca into opensearch-project:main Jun 24, 2024
13 of 20 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 24, 2024
* Abstract FlintIndex client

Signed-off-by: Tomoyuki Morita <[email protected]>

* Fix log

Signed-off-by: Tomoyuki Morita <[email protected]>

* Fix test function name

Signed-off-by: Tomoyuki Morita <[email protected]>

---------

Signed-off-by: Tomoyuki Morita <[email protected]>
(cherry picked from commit b2403ca)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ykmr1224 pushed a commit that referenced this pull request Jun 25, 2024
* Abstract FlintIndex client



* Fix log



* Fix test function name



---------


(cherry picked from commit b2403ca)

Signed-off-by: Tomoyuki Morita <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jzonthemtn pushed a commit to jzonthemtn/sql that referenced this pull request Aug 28, 2024
* Abstract FlintIndex client

Signed-off-by: Tomoyuki Morita <[email protected]>

* Fix log

Signed-off-by: Tomoyuki Morita <[email protected]>

* Fix test function name

Signed-off-by: Tomoyuki Morita <[email protected]>

---------

Signed-off-by: Tomoyuki Morita <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x maintenance Improves code quality, but not the product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants