Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass down request context to data accessors #2715

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

ykmr1224
Copy link
Collaborator

@ykmr1224 ykmr1224 commented Jun 5, 2024

Description

  • Pass down request context to data accessors to allow data accessors to use the information passed in the context.
  • Renamed the class name to AsyncQueryRequestContext to make it more specific and avoid confusion.

Issues Resolved

n/a

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ykmr1224 ykmr1224 merged commit c0a5123 into opensearch-project:main Jun 7, 2024
22 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-2715-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c0a51239a60a794506cf8f4ac803279550870dfd
# Push it to GitHub
git push --set-upstream origin backport/backport-2715-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2715-to-2.x.

ykmr1224 added a commit to ykmr1224/sql that referenced this pull request Jun 7, 2024
Signed-off-by: Tomoyuki Morita <[email protected]>

(cherry picked from commit c0a5123)
ykmr1224 added a commit to ykmr1224/sql that referenced this pull request Jun 7, 2024
Signed-off-by: Tomoyuki Morita <[email protected]>
(cherry picked from commit c0a5123)
ykmr1224 added a commit that referenced this pull request Jun 7, 2024
Signed-off-by: Tomoyuki Morita <[email protected]>
(cherry picked from commit c0a5123)
@ykmr1224 ykmr1224 deleted the dqs/request-context branch June 12, 2024 22:16
jzonthemtn pushed a commit to jzonthemtn/sql that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport-failed maintenance Improves code quality, but not the product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants