Provide a way to modify spark parameters #2691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoyuki Morita <[email protected]>
ykmr1224
force-pushed
the
dqs/spark-parameter
branch
from
4915f1a to
92197a8
Compare
ykmr1224
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
ykmr1224
added
backport 2.x
maintenance
seankao-az
reviewed
May 24, 2024
spark/src/main/java/org/opensearch/sql/spark/asyncquery/model/SparkSubmitParameters.java
Show resolved
Hide resolved
spark/src/main/java/org/opensearch/sql/spark/asyncquery/model/SparkSubmitParameters.java
Show resolved
Hide resolved
spark/src/main/java/org/opensearch/sql/spark/config/SparkExecutionEngineConfigSupplierImpl.java
Show resolved
Hide resolved
spark/src/main/java/org/opensearch/sql/spark/execution/session/InteractiveSession.java
Show resolved
Hide resolved
seankao-az
reviewed
May 24, 2024
| sparkExecutionEngineConfig.setClusterName(clusterName.value()); | ||
| return sparkExecutionEngineConfig; | ||
| builder.clusterName(clusterName.value()); | ||
| return builder.build(); |
There was a problem hiding this comment.
builder calls isn't chained like builder.applicationId(...).executionRoleARN(...).build()
does builder also work this way?
There was a problem hiding this comment.
(pretty sure I included this in initial review, dunno why this comment is missing)
There was a problem hiding this comment.
Good point. Fixed!
Signed-off-by: Tomoyuki Morita <[email protected]>
Signed-off-by: Tomoyuki Morita <[email protected]>
seankao-az
previously approved these changes
May 24, 2024
rupal-bq
previously approved these changes
May 24, 2024
Signed-off-by: Tomoyuki Morita <[email protected]>
rupal-bq
approved these changes
May 24, 2024
seankao-az
approved these changes
May 24, 2024
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-2691-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5a2c199b64f1e02975b258e8711f3beb4c5d81ed
# Push it to GitHub
git push --set-upstream origin backport/backport-2691-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.xThen, create a pull request where the |
ykmr1224
added a commit
to ykmr1224/sql
that referenced
this pull request
May 24, 2024
* Provide a way to modify spark parameters Signed-off-by: Tomoyuki Morita <[email protected]> * Address review comment Signed-off-by: Tomoyuki Morita <[email protected]> * Address review comment Signed-off-by: Tomoyuki Morita <[email protected]> * Address review comment Signed-off-by: Tomoyuki Morita <[email protected]> --------- Signed-off-by: Tomoyuki Morita <[email protected]> (cherry picked from commit 5a2c199)
6 tasks
ykmr1224
added a commit
that referenced
this pull request
May 24, 2024
* Provide a way to modify spark parameters Signed-off-by: Tomoyuki Morita <[email protected]> * Address review comment Signed-off-by: Tomoyuki Morita <[email protected]> * Address review comment Signed-off-by: Tomoyuki Morita <[email protected]> * Address review comment Signed-off-by: Tomoyuki Morita <[email protected]> --------- Signed-off-by: Tomoyuki Morita <[email protected]> (cherry picked from commit 5a2c199)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
n/a
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.