Make models free of XContent #2677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoyuki Morita <[email protected]>
ykmr1224
added
backport 2.x
maintenance
ykmr1224
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
penghuo
reviewed
May 17, 2024
|
|
||
| package org.opensearch.sql.spark.execution.statestore; | ||
|
|
||
| public interface CopyBuilder<T> { |
| StatementState.RUNNING.getState(), | ||
| StatementState.WAITING.getState()))); | ||
| } | ||
|
|
||
| @SuppressWarnings("unchecked") | ||
| private <T extends StateModel> XContentSerializer<T> getXContentSerializer(T st) { |
There was a problem hiding this comment.
XContentSerializer still depend on OpenSearch library?
There was a problem hiding this comment.
I'm not quite sure the intention of the question, but XContentSerializer is more on OpenSearch side since the XContent is OpenSearch specific content serialization. It won't be used for non-opensearch environment.
Signed-off-by: Tomoyuki Morita <[email protected]>
seankao-az
approved these changes
May 17, 2024
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-2677-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2c849f76876a8a0422debb0e0f905a9ee81c9990
# Push it to GitHub
git push --set-upstream origin backport/backport-2677-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.xThen, create a pull request where the |
6 tasks
ykmr1224
added a commit
that referenced
this pull request
May 20, 2024
* Make models free of XContent Signed-off-by: Tomoyuki Morita <[email protected]> (cherry picked from commit afec315) * Add comments Signed-off-by: Tomoyuki Morita <[email protected]> (cherry picked from commit 2c849f7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
n/a
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.