Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict the scope of cancel API #2548

Merged
merged 9 commits into from
Mar 13, 2024
Merged

Conversation

penghuo
Copy link
Collaborator

@penghuo penghuo commented Mar 11, 2024

Description

Issues Resolved

#2430

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@penghuo penghuo self-assigned this Mar 11, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 98.27586% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.47%. Comparing base (353b0d7) to head (24369b1).

Files Patch % Lines
.../spark/asyncquery/model/AsyncQueryJobMetadata.java 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2548      +/-   ##
============================================
+ Coverage     95.43%   95.47%   +0.03%     
- Complexity     5031     5046      +15     
============================================
  Files           484      486       +2     
  Lines         14032    14085      +53     
  Branches        940      943       +3     
============================================
+ Hits          13392    13448      +56     
+ Misses          619      614       -5     
- Partials         21       23       +2     
Flag Coverage Δ
sql-engine 95.47% <98.27%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vmmusings
Copy link
Member

YANG-DB
YANG-DB previously approved these changes Mar 12, 2024
penghuo added 5 commits March 12, 2024 17:44
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@vmmusings vmmusings merged commit a84c3ef into opensearch-project:main Mar 13, 2024
27 of 28 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 13, 2024
* Restric cancel the scope of cancel API

Signed-off-by: Peng Huo <[email protected]>

* Fix UT, batch query only been used for REFRESH

Signed-off-by: Peng Huo <[email protected]>

* Update style

Signed-off-by: Peng Huo <[email protected]>

* support cancel refresh query

Signed-off-by: Peng Huo <[email protected]>

* fix UT

Signed-off-by: Peng Huo <[email protected]>

* refactor code

Signed-off-by: Peng Huo <[email protected]>

* update doc

Signed-off-by: Peng Huo <[email protected]>

* refactor code

Signed-off-by: Peng Huo <[email protected]>

---------

Signed-off-by: Peng Huo <[email protected]>
(cherry picked from commit a84c3ef)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
penghuo pushed a commit that referenced this pull request Mar 14, 2024
* Restric cancel the scope of cancel API



* Fix UT, batch query only been used for REFRESH



* Update style



* support cancel refresh query



* fix UT



* refactor code



* update doc



* refactor code



---------


(cherry picked from commit a84c3ef)

Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants