-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict the scope of cancel API #2548
Conversation
Signed-off-by: Peng Huo <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2548 +/- ##
============================================
+ Coverage 95.43% 95.47% +0.03%
- Complexity 5031 5046 +15
============================================
Files 484 486 +2
Lines 14032 14085 +53
Branches 940 943 +3
============================================
+ Hits 13392 13448 +56
+ Misses 619 614 -5
- Partials 21 23 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
spark/src/main/java/org/opensearch/sql/spark/dispatcher/BatchQueryHandler.java
Outdated
Show resolved
Hide resolved
Can we update documentation https://github.com/penghuo/os-sql/blob/issue2430/docs/user/interfaces/asyncqueryinterface.rst ?? |
spark/src/main/java/org/opensearch/sql/spark/dispatcher/InteractiveQueryHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
spark/src/main/java/org/opensearch/sql/spark/dispatcher/SparkQueryDispatcher.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
* Restric cancel the scope of cancel API Signed-off-by: Peng Huo <[email protected]> * Fix UT, batch query only been used for REFRESH Signed-off-by: Peng Huo <[email protected]> * Update style Signed-off-by: Peng Huo <[email protected]> * support cancel refresh query Signed-off-by: Peng Huo <[email protected]> * fix UT Signed-off-by: Peng Huo <[email protected]> * refactor code Signed-off-by: Peng Huo <[email protected]> * update doc Signed-off-by: Peng Huo <[email protected]> * refactor code Signed-off-by: Peng Huo <[email protected]> --------- Signed-off-by: Peng Huo <[email protected]> (cherry picked from commit a84c3ef) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Restric cancel the scope of cancel API * Fix UT, batch query only been used for REFRESH * Update style * support cancel refresh query * fix UT * refactor code * update doc * refactor code --------- (cherry picked from commit a84c3ef) Signed-off-by: Peng Huo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
For select query
For Flint index management query
CREATE SI/CI/MV (auto_refresh=true)
can not be cancelled, error message is "Can not cancel index DML query"REFRESH SI/CI/MV
can be cancelled.OpenSearch 2.12 Upgrade Impact
Issues Resolved
#2430
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.