-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporary fixes for build errors #2476
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2476 +/- ##
=========================================
Coverage 95.41% 95.41%
Complexity 5000 5000
=========================================
Files 479 479
Lines 13950 13950
Branches 937 937
=========================================
Hits 13310 13310
Misses 618 618
Partials 22 22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks Vamsi, just wanna link this fix to the issue for tracking #2468 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Thanks Vamsi
@@ -26,6 +26,7 @@ skippingIndexStatement | |||
| refreshSkippingIndexStatement | |||
| describeSkippingIndexStatement | |||
| dropSkippingIndexStatement | |||
| vacuumSkippingIndexStatement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to update .g4?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These g4 files come from opensearch-spark. We always keep them up to date.
core/src/test/java/org/opensearch/sql/expression/datetime/DateTimeFunctionTest.java
Show resolved
Hide resolved
Signed-off-by: Vamsi Manohar <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-2476-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6fcf31b7dc4a9a1a80a1e95c30fc7e72408e7812
# Push it to GitHub
git push --set-upstream origin backport/backport-2476-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.x Then, create a pull request where the |
Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit 6fcf31b)
Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit 6fcf31b)
Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit 6fcf31b)
Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit 6fcf31b)
Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit 6fcf31b)
Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit 6fcf31b)
Description
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.