Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spark Execution Engine Config Refactor #2249

Conversation

vamsimanohar
Copy link
Member

@vamsimanohar vamsimanohar commented Oct 6, 2023

Description

  • Refactoring for Spark Execution Engine Config Reading.
  • SparkExecutionEngineConfigClusterSetting is the POJO class for reading plugins.query.executionengine.spark.config cluster setting.
  • SparkExecutionEngineConfigSupplier is the new interface responsible for providing the configuration to AsyncQueryExecutorService.
  • SparkExecutionEngineConfig is the Interface between AsyncQueryExecutorService and SparkExecutionEngineConfigSupplier.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #2249 (cf86fa0) into main (55e8e84) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2249      +/-   ##
============================================
+ Coverage     96.59%   96.60%   +0.01%     
- Complexity     4730     4738       +8     
============================================
  Files           439      442       +3     
  Lines         12691    12741      +50     
  Branches        871      876       +5     
============================================
+ Hits          12259    12309      +50     
  Misses          424      424              
  Partials          8        8              
Flag Coverage Δ
sql-engine 96.60% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...park/asyncquery/AsyncQueryExecutorServiceImpl.java 100.00% <100.00%> (ø)
...nfig/SparkExecutionEngineConfigClusterSetting.java 100.00% <100.00%> (ø)
...config/SparkExecutionEngineConfigSupplierImpl.java 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

@vamsimanohar vamsimanohar force-pushed the spark-execution-engine-config-refactor branch 2 times, most recently from d398c0c to 884b6b2 Compare October 6, 2023 22:42
penghuo
penghuo previously approved these changes Oct 7, 2023
@vamsimanohar vamsimanohar self-assigned this Oct 7, 2023
@vamsimanohar vamsimanohar added backport 2.x backport 2.11 maintenance Improves code quality, but not the product Flint labels Oct 7, 2023
@vamsimanohar vamsimanohar force-pushed the spark-execution-engine-config-refactor branch from 884b6b2 to cf86fa0 Compare October 7, 2023 04:43
@vamsimanohar vamsimanohar merged commit b654e43 into opensearch-project:main Oct 9, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 9, 2023
Signed-off-by: Vamsi Manohar <[email protected]>
(cherry picked from commit b654e43)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 9, 2023
Signed-off-by: Vamsi Manohar <[email protected]>
(cherry picked from commit b654e43)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vamsimanohar pushed a commit that referenced this pull request Oct 9, 2023
(cherry picked from commit b654e43)

Signed-off-by: Vamsi Manohar <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vamsimanohar pushed a commit that referenced this pull request Oct 9, 2023
(cherry picked from commit b654e43)

Signed-off-by: Vamsi Manohar <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport 2.11 Flint maintenance Improves code quality, but not the product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants