-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spark Execution Engine Config Refactor #2249
Merged
vamsimanohar
merged 1 commit into
opensearch-project:main
from
vamsimanohar:spark-execution-engine-config-refactor
Oct 9, 2023
Merged
Spark Execution Engine Config Refactor #2249
vamsimanohar
merged 1 commit into
opensearch-project:main
from
vamsimanohar:spark-execution-engine-config-refactor
Oct 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vamsimanohar
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
October 6, 2023 22:27
Codecov Report
@@ Coverage Diff @@
## main #2249 +/- ##
============================================
+ Coverage 96.59% 96.60% +0.01%
- Complexity 4730 4738 +8
============================================
Files 439 442 +3
Lines 12691 12741 +50
Branches 871 876 +5
============================================
+ Hits 12259 12309 +50
Misses 424 424
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
vamsimanohar
force-pushed
the
spark-execution-engine-config-refactor
branch
2 times, most recently
from
October 6, 2023 22:42
d398c0c
to
884b6b2
Compare
penghuo
reviewed
Oct 6, 2023
spark/src/main/java/org/opensearch/sql/spark/config/SparkExecutionEngineConfigSupplierImpl.java
Show resolved
Hide resolved
penghuo
previously approved these changes
Oct 7, 2023
vamsimanohar
added
backport 2.x
backport 2.11
maintenance
Improves code quality, but not the product
Flint
labels
Oct 7, 2023
Signed-off-by: Vamsi Manohar <[email protected]>
vamsimanohar
force-pushed
the
spark-execution-engine-config-refactor
branch
from
October 7, 2023 04:43
884b6b2
to
cf86fa0
Compare
penghuo
approved these changes
Oct 9, 2023
ps48
approved these changes
Oct 9, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 9, 2023
Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit b654e43) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 9, 2023
Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit b654e43) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vamsimanohar
pushed a commit
that referenced
this pull request
Oct 9, 2023
(cherry picked from commit b654e43) Signed-off-by: Vamsi Manohar <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vamsimanohar
pushed a commit
that referenced
this pull request
Oct 9, 2023
(cherry picked from commit b654e43) Signed-off-by: Vamsi Manohar <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SparkExecutionEngineConfigClusterSetting
is the POJO class for readingplugins.query.executionengine.spark.config
cluster setting.SparkExecutionEngineConfigSupplier
is the new interface responsible for providing the configuration toAsyncQueryExecutorService
.SparkExecutionEngineConfig
is the Interface between AsyncQueryExecutorService and SparkExecutionEngineConfigSupplier.Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.