Fixed exception when datasource is updated with existing configuration. #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmmusings
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
Signed-off-by: Vamsi Manohar <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2006 +/- ##
=========================================
Coverage 97.30% 97.30%
- Complexity 4622 4623 +1
=========================================
Files 407 407
Lines 11934 11935 +1
Branches 827 828 +1
=========================================
+ Hits 11612 11613 +1
Misses 315 315
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ps48
approved these changes
Aug 22, 2023
rupal-bq
approved these changes
Aug 22, 2023
This was referenced Aug 22, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 22, 2023
#2006) Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit b3fd4c4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 22, 2023
#2006) Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit b3fd4c4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vmmusings
pushed a commit
that referenced
this pull request
Aug 22, 2023
#2006) (#2009) (cherry picked from commit b3fd4c4) Signed-off-by: Vamsi Manohar <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vmmusings
pushed a commit
that referenced
this pull request
Aug 22, 2023
#2006) (#2008) (cherry picked from commit b3fd4c4) Signed-off-by: Vamsi Manohar <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the current state when datasource is updated with existing configuration, it results in 503 error.
With this PR, it returns 200.
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.