Developer guide update with Spotless details #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mitchell Gale <[email protected]>
MitchellGale
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
acarbonetto
reviewed
Aug 21, 2023
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2000 +/- ##
============================================
- Coverage 97.33% 97.30% -0.04%
+ Complexity 4657 4621 -36
============================================
Files 408 407 -1
Lines 12097 11933 -164
Branches 829 826 -3
============================================
- Hits 11775 11611 -164
Misses 315 315
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Mitchell Gale <[email protected]>
Co-authored-by: Yury-Fridlyand <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
Co-authored-by: Yury-Fridlyand <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
Co-authored-by: Yury-Fridlyand <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
Co-authored-by: Yury-Fridlyand <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
Co-authored-by: Yury-Fridlyand <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Yury-Fridlyand
approved these changes
Aug 21, 2023
acarbonetto
approved these changes
Aug 21, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 21, 2023
* Added spotless java format rules to dev guide Signed-off-by: Mitchell Gale <[email protected]> * Fixed formatting of URLS in DEVELOPER_GUIDE.rst Signed-off-by: Mitchell Gale <[email protected]> * addressed PR comments Signed-off-by: Mitchell Gale <[email protected]> * addressed PR comments Signed-off-by: Mitchell Gale <[email protected]> * addressed PR comments Signed-off-by: Mitchell Gale <[email protected]> * Update DEVELOPER_GUIDE.rst Co-authored-by: Yury-Fridlyand <[email protected]> Signed-off-by: Mitchell Gale <[email protected]> * Update DEVELOPER_GUIDE.rst Co-authored-by: Yury-Fridlyand <[email protected]> Signed-off-by: Mitchell Gale <[email protected]> * Update DEVELOPER_GUIDE.rst Co-authored-by: Yury-Fridlyand <[email protected]> Signed-off-by: Mitchell Gale <[email protected]> * Update DEVELOPER_GUIDE.rst Co-authored-by: Yury-Fridlyand <[email protected]> Signed-off-by: Mitchell Gale <[email protected]> * Update DEVELOPER_GUIDE.rst Co-authored-by: Yury-Fridlyand <[email protected]> Signed-off-by: Mitchell Gale <[email protected]> * fixed link format Signed-off-by: Mitchell Gale <[email protected]> --------- Signed-off-by: Mitchell Gale <[email protected]> Signed-off-by: Mitchell Gale <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]> (cherry picked from commit 8f650e8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
acarbonetto
pushed a commit
that referenced
this pull request
Aug 21, 2023
* Added spotless java format rules to dev guide * Fixed formatting of URLS in DEVELOPER_GUIDE.rst * addressed PR comments * addressed PR comments * addressed PR comments * Update DEVELOPER_GUIDE.rst * Update DEVELOPER_GUIDE.rst * Update DEVELOPER_GUIDE.rst * Update DEVELOPER_GUIDE.rst * Update DEVELOPER_GUIDE.rst * fixed link format --------- (cherry picked from commit 8f650e8) Signed-off-by: Mitchell Gale <[email protected]> Signed-off-by: Mitchell Gale <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Yury-Fridlyand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds more information and links about spotless and google java formatter in the developer guide.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.