Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Update backport CI, add PR merged condition #1970

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Aug 16, 2023

Description

Update backport CI, add PR merged condition #1952

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #1970 (8880c9f) into 2.x (1b5a936) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                2.x    #1970   +/-   ##
=========================================
  Coverage     97.42%   97.42%           
  Complexity     4647     4647           
=========================================
  Files           408      408           
  Lines         11528    11528           
  Branches        837      837           
=========================================
  Hits          11231    11231           
  Misses          290      290           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@ -15,15 +16,15 @@ jobs:
steps:
- name: GitHub App token
id: github_app_token
uses: tibdex/github-app-token@v1.7.0
uses: tibdex/github-app-token@v1.5.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the downgrade?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to keep this in sync with all our other repos. Also, I didn't see huge changes between both marketplace versions: tibdex/github-app-token@v1.7.0...v1.5.0.

@ps48 ps48 merged commit d9a78df into opensearch-project:2.x Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants