Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#1506) Remove reservedSymbolTable and replace with HIDDEN_FIELD_NAME… #1964

Merged

Conversation

acarbonetto
Copy link
Collaborator

(cherry picked from commit 5381a6f)

Description

Backport #1936

Issues Resolved

backport #1936

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

… HIDDEN_FIELD_NAME (opensearch-project#1936)

* (opensearch-project#1506) Remove reservedSymbolTable and replace with HIDDEN_FIELD_NAME (#323)

* opensearch-project#1506: Remove reservedSymbolTable and use HIDDEN_FIELD_NAME instead

Signed-off-by: acarbonetto <[email protected]>

* opensearch-project#1506: Remove reservedSymbolTable and use HIDDEN_FIELD_NAME instead

Signed-off-by: acarbonetto <[email protected]>

* opensearch-project#1506: Fix checkstyle errors

Signed-off-by: acarbonetto <[email protected]>

---------

Signed-off-by: acarbonetto <[email protected]>

* opensearch-project#1506: spotless apply

Signed-off-by: acarbonetto <[email protected]>

---------

Signed-off-by: acarbonetto <[email protected]>
(cherry picked from commit 5381a6f)
Signed-off-by: acarbonetto <[email protected]>
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #1964 (028b89a) into 2.x (1b5a936) will increase coverage by 0.00%.
Report is 1 commits behind head on 2.x.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##                2.x    #1964   +/-   ##
=========================================
  Coverage     97.42%   97.42%           
+ Complexity     4647     4646    -1     
=========================================
  Files           408      408           
  Lines         11528    11529    +1     
  Branches        837      837           
=========================================
+ Hits          11231    11232    +1     
  Misses          290      290           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.42% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...a/org/opensearch/sql/analysis/TypeEnvironment.java 100.00% <ø> (ø)
...ain/java/org/opensearch/sql/analysis/Analyzer.java 100.00% <100.00%> (ø)
...rg/opensearch/sql/analysis/ExpressionAnalyzer.java 100.00% <100.00%> (ø)
.../org/opensearch/sql/analysis/symbol/Namespace.java 100.00% <100.00%> (ø)

@acarbonetto acarbonetto merged commit 0b419ff into opensearch-project:2.x Aug 21, 2023
@acarbonetto acarbonetto deleted the backport/backport-1936-to-2.x branch August 21, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants