-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix doctest data #1902
Fix doctest data #1902
Conversation
Signed-off-by: Yury-Fridlyand <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1902 +/- ##
=========================================
Coverage 97.39% 97.39%
Complexity 4603 4603
=========================================
Files 401 401
Lines 11397 11397
Branches 835 835
=========================================
Hits 11100 11100
Misses 290 290
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's very odd how this was missed. Also very odd that doctests don't use the bulk endpoint.
Signed-off-by: Yury-Fridlyand <[email protected]> (cherry picked from commit ff059f0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit ff059f0) Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Clean up doctest test data. Fortunately, no test failed due to incorrect import.
Doctest uses python client to manipulate with test data and it interpreted
{"index":{"_id":"0"}}
as a doc to import. Fortunately, opensearch DSL ignores such docs for queries being tested, so it didn't affect the test.Issues Resolved
Fix doctest samples.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.