Fix CSV/RAW output header being application/json rather than plain/text #1779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix ML-commons missing dependency. Signed-off-by: Yury-Fridlyand <[email protected]> * Fix `mockito` dependency. Signed-off-by: Yury-Fridlyand <[email protected]> * Revert changes in `:opensearch` since it is not needed anymore. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Matthew Wells <[email protected]>
…t-fix Signed-off-by: Matthew Wells <[email protected]>
* Fixed bug where CSV/RAW outputs as JSON rather than plain text Signed-off-by: Matthew Wells <[email protected]>
matthewryanwells
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
Yury-Fridlyand
approved these changes
Jun 26, 2023
Codecov Report
@@ Coverage Diff @@
## main #1779 +/- ##
=========================================
Coverage 97.29% 97.29%
- Complexity 4408 4410 +2
=========================================
Files 388 388
Lines 10944 10946 +2
Branches 774 774
=========================================
+ Hits 10648 10650 +2
Misses 289 289
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
acarbonetto
approved these changes
Jun 27, 2023
|
@matthewryanwells have we determined if this fixes nested and objects in the Dashboard too? |
@acarbonetto I can confirm that this fixes the nested, objects, and any other issues with output as the problem was how csv and raw were being handled, rather than the specific thing being processed. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 27, 2023
…xt (#1779) * Fix CI (#1760) * Fix ML-commons missing dependency. Signed-off-by: Yury-Fridlyand <[email protected]> * Fix `mockito` dependency. Signed-off-by: Yury-Fridlyand <[email protected]> * Revert changes in `:opensearch` since it is not needed anymore. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Matthew Wells <[email protected]> * Fix CSV/RAW outputting wrong format (#279) * Fixed bug where CSV/RAW outputs as JSON rather than plain text Signed-off-by: Matthew Wells <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Matthew Wells <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]> (cherry picked from commit 1ec696d)
6 tasks
Yury-Fridlyand
pushed a commit
that referenced
this pull request
Jun 28, 2023
* Fix CSV/RAW output header being application/json rather than plain/text (#1779) * Fix CI (#1760) * Fix ML-commons missing dependency. Signed-off-by: Yury-Fridlyand <[email protected]> * Fix `mockito` dependency. Signed-off-by: Yury-Fridlyand <[email protected]> * Revert changes in `:opensearch` since it is not needed anymore. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Matthew Wells <[email protected]> * Fix CSV/RAW outputting wrong format (#279) * Fixed bug where CSV/RAW outputs as JSON rather than plain text Signed-off-by: Matthew Wells <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Matthew Wells <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]> (cherry picked from commit 1ec696d) * updated tests Signed-off-by: Matthew Wells <[email protected]> * updated tests to return name Signed-off-by: Matthew Wells <[email protected]> * changed tests to return value Signed-off-by: Matthew Wells <[email protected]> * removed unneeded imports Signed-off-by: Matthew Wells <[email protected]> --------- Signed-off-by: Matthew Wells <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When making SQL calls with
csvorrawoutputs the formatting would be incorrect as the header sets the format toapplication/jsonrather thanplain/textlike the legacy engine did.This PR adds a format getter to both response formatters to allow it to be set correctly.
Issues Resolved
#1572
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.