-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Field Star in Nested Function #1773
Merged
forestmvey
merged 5 commits into
opensearch-project:main
from
Bit-Quill:integ-nested-all-fields
Jun 28, 2023
Merged
Add Support for Field Star in Nested Function #1773
forestmvey
merged 5 commits into
opensearch-project:main
from
Bit-Quill:integ-nested-all-fields
Jun 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forestmvey
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
acarbonetto and
GumpacG
as code owners
June 23, 2023 21:26
Codecov Report
@@ Coverage Diff @@
## main #1773 +/- ##
============================================
+ Coverage 97.30% 97.32% +0.01%
- Complexity 4442 4458 +16
============================================
Files 388 388
Lines 11000 11050 +50
Branches 785 790 +5
============================================
+ Hits 10704 10754 +50
Misses 289 289
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Yury-Fridlyand
previously approved these changes
Jun 24, 2023
core/src/main/java/org/opensearch/sql/ast/expression/NestedAllTupleFields.java
Outdated
Show resolved
Hide resolved
Please, fix DCO |
forestmvey
force-pushed
the
integ-nested-all-fields
branch
from
June 26, 2023 22:17
c306bf2
to
f935476
Compare
Yury-Fridlyand
previously approved these changes
Jun 27, 2023
matthewryanwells
approved these changes
Jun 27, 2023
GumpacG
previously approved these changes
Jun 27, 2023
forestmvey
force-pushed
the
integ-nested-all-fields
branch
from
June 27, 2023 22:18
14ad058
to
4461ae8
Compare
Signed-off-by: forestmvey <[email protected]>
GumpacG
previously approved these changes
Jun 28, 2023
MitchellGale
approved these changes
Jun 28, 2023
Signed-off-by: forestmvey <[email protected]>
GumpacG
approved these changes
Jun 28, 2023
Yury-Fridlyand
approved these changes
Jun 28, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 28, 2023
* Add Support for Field Star in Nested Function. Signed-off-by: forestmvey <[email protected]> * Removing toString for NestedAllTupleFields. Signed-off-by: forestmvey <[email protected]> * Adding IT test for nested all fields in invalid clause of SQL statement. Signed-off-by: forestmvey <[email protected]> * Use utility function for checking is nested in NestedAnalyzer. Signed-off-by: forestmvey <[email protected]> * Formatting fixes. Signed-off-by: forestmvey <[email protected]> --------- Signed-off-by: forestmvey <[email protected]> (cherry picked from commit fa840e0)
forestmvey
added a commit
that referenced
this pull request
Jun 28, 2023
* Add Support for Field Star in Nested Function. Signed-off-by: forestmvey <[email protected]> * Removing toString for NestedAllTupleFields. Signed-off-by: forestmvey <[email protected]> * Adding IT test for nested all fields in invalid clause of SQL statement. Signed-off-by: forestmvey <[email protected]> * Use utility function for checking is nested in NestedAnalyzer. Signed-off-by: forestmvey <[email protected]> * Formatting fixes. Signed-off-by: forestmvey <[email protected]> --------- Signed-off-by: forestmvey <[email protected]> (cherry picked from commit fa840e0) Signed-off-by: forestmvey <[email protected]>
forestmvey
added a commit
that referenced
this pull request
Jun 28, 2023
* Add Support for Field Star in Nested Function. Signed-off-by: forestmvey <[email protected]> * Removing toString for NestedAllTupleFields. Signed-off-by: forestmvey <[email protected]> * Adding IT test for nested all fields in invalid clause of SQL statement. Signed-off-by: forestmvey <[email protected]> * Use utility function for checking is nested in NestedAnalyzer. Signed-off-by: forestmvey <[email protected]> * Formatting fixes. Signed-off-by: forestmvey <[email protected]> --------- Signed-off-by: forestmvey <[email protected]> (cherry picked from commit fa840e0) Signed-off-by: forestmvey <[email protected]>
matthewryanwells
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jul 7, 2023
* Add Support for Field Star in Nested Function. Signed-off-by: forestmvey <[email protected]> * Removing toString for NestedAllTupleFields. Signed-off-by: forestmvey <[email protected]> * Adding IT test for nested all fields in invalid clause of SQL statement. Signed-off-by: forestmvey <[email protected]> * Use utility function for checking is nested in NestedAnalyzer. Signed-off-by: forestmvey <[email protected]> * Formatting fixes. Signed-off-by: forestmvey <[email protected]> --------- Signed-off-by: forestmvey <[email protected]>
matthewryanwells
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jul 7, 2023
* Add Support for Field Star in Nested Function. Signed-off-by: forestmvey <[email protected]> * Removing toString for NestedAllTupleFields. Signed-off-by: forestmvey <[email protected]> * Adding IT test for nested all fields in invalid clause of SQL statement. Signed-off-by: forestmvey <[email protected]> * Use utility function for checking is nested in NestedAnalyzer. Signed-off-by: forestmvey <[email protected]> * Formatting fixes. Signed-off-by: forestmvey <[email protected]> --------- Signed-off-by: forestmvey <[email protected]> Signed-off-by: Matthew Wells <[email protected]>
forestmvey
added a commit
that referenced
this pull request
Jul 11, 2023
* Add Support for Field Star in Nested Function. Signed-off-by: forestmvey <[email protected]> * Removing toString for NestedAllTupleFields. Signed-off-by: forestmvey <[email protected]> * Adding IT test for nested all fields in invalid clause of SQL statement. Signed-off-by: forestmvey <[email protected]> * Use utility function for checking is nested in NestedAnalyzer. Signed-off-by: forestmvey <[email protected]> * Formatting fixes. Signed-off-by: forestmvey <[email protected]> --------- Signed-off-by: forestmvey <[email protected]> (cherry picked from commit fa840e0) Signed-off-by: forestmvey <[email protected]>
forestmvey
added a commit
that referenced
this pull request
Jul 11, 2023
* Add Support for Field Star in Nested Function. * Removing toString for NestedAllTupleFields. * Adding IT test for nested all fields in invalid clause of SQL statement. * Use utility function for checking is nested in NestedAnalyzer. * Formatting fixes. --------- (cherry picked from commit fa840e0) Signed-off-by: forestmvey <[email protected]> Co-authored-by: Forest Vey <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
* Add Support for Field Star in Nested Function. Signed-off-by: forestmvey <[email protected]> * Removing toString for NestedAllTupleFields. Signed-off-by: forestmvey <[email protected]> * Adding IT test for nested all fields in invalid clause of SQL statement. Signed-off-by: forestmvey <[email protected]> * Use utility function for checking is nested in NestedAnalyzer. Signed-off-by: forestmvey <[email protected]> * Formatting fixes. Signed-off-by: forestmvey <[email protected]> --------- Signed-off-by: forestmvey <[email protected]> (cherry picked from commit fa840e0)
forestmvey
added a commit
that referenced
this pull request
Jul 11, 2023
* Add Support for Field Star in Nested Function. Signed-off-by: forestmvey <[email protected]> * Removing toString for NestedAllTupleFields. Signed-off-by: forestmvey <[email protected]> * Adding IT test for nested all fields in invalid clause of SQL statement. Signed-off-by: forestmvey <[email protected]> * Use utility function for checking is nested in NestedAnalyzer. Signed-off-by: forestmvey <[email protected]> * Formatting fixes. Signed-off-by: forestmvey <[email protected]> --------- Signed-off-by: forestmvey <[email protected]> (cherry picked from commit fa840e0) Signed-off-by: forestmvey <[email protected]>
forestmvey
added a commit
that referenced
this pull request
Jul 11, 2023
* Add Support for Field Star in Nested Function. Signed-off-by: forestmvey <[email protected]> * Removing toString for NestedAllTupleFields. Signed-off-by: forestmvey <[email protected]> * Adding IT test for nested all fields in invalid clause of SQL statement. Signed-off-by: forestmvey <[email protected]> * Use utility function for checking is nested in NestedAnalyzer. Signed-off-by: forestmvey <[email protected]> * Formatting fixes. Signed-off-by: forestmvey <[email protected]> --------- Signed-off-by: forestmvey <[email protected]> (cherry picked from commit fa840e0) Signed-off-by: forestmvey <[email protected]>
Yury-Fridlyand
pushed a commit
that referenced
this pull request
Jul 11, 2023
* Add Support for Field Star in Nested Function. * Removing toString for NestedAllTupleFields. * Adding IT test for nested all fields in invalid clause of SQL statement. * Use utility function for checking is nested in NestedAnalyzer. * Formatting fixes. --------- (cherry picked from commit fa840e0) Signed-off-by: forestmvey <[email protected]> Co-authored-by: Forest Vey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for using the
*
at end of field parameter in the nested function. All nested fields under supplied path will be expanded as column identifiers. Grammar has been added to only support theAllTupleFields
usage with the nested function since this change will effect field usage in all queries and needs further planning with V2 implementation.Example Queries
Issues Resolved
Portion of Issue: 1111
Changes From Legacy
Edge Cases
Queries that produce repeating column identifiers like:
Or
Will result in error:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.