-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop prometheus in doctest build.gradle now runs upon project failure in startOpenSearch #1747
Stop prometheus in doctest build.gradle now runs upon project failure in startOpenSearch #1747
Conversation
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
Stop prometheus in doctest build.gradle now runs upon project failure in startOpenSearch
Codecov Report
@@ Coverage Diff @@
## main #1747 +/- ##
=========================================
Coverage 97.33% 97.33%
Complexity 4408 4408
=========================================
Files 388 388
Lines 10938 10938
Branches 773 773
=========================================
Hits 10647 10647
Misses 284 284
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1747-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ded014d1f5cea3ee8fda282e831f67ad66461961
# Push it to GitHub
git push --set-upstream origin backport/backport-1747-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
… in startOpenSearch (opensearch-project#1747) * Stop prometheus now runs when project start fails :) Signed-off-by: Mitchell Gale <[email protected]> * Bump bwc opensearch version to 2.9 Signed-off-by: MaxKsyunz <[email protected]> --------- Signed-off-by: Mitchell Gale <[email protected]> Signed-off-by: MaxKsyunz <[email protected]> Co-authored-by: MaxKsyunz <[email protected]>
Stop Prometheus was not running in doctest in cases of some run errors causing Prometheus to keep running after build is stopped. This will cause failure upon next attempt of startPrometheus due to the existing Prometheus running on localhost:9090.
Steps to reproduce error that is fixed.
Same steps can be taken working from this PR branch and it will not show the error in step 6.
Issues Resolved
1083
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.