[Backport 2.x] Pagination Phase 2: Support ORDER BY clauses and queries without FROM.
#1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…ROM`. (#1599) * Support `ORDER BY` clauses in pagination and queries without `FROM`. Signed-off-by: Yury-Fridlyand <[email protected]> * Fix IT. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> (cherry picked from commit 94d5479)
opensearch-trigger-bot
bot
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.x #1745 +/- ##
=========================================
Coverage 97.31% 97.31%
Complexity 4374 4374
=========================================
Files 385 385
Lines 10849 10849
Branches 763 763
=========================================
Hits 10558 10558
Misses 284 284
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. |
GumpacG
approved these changes
Jun 15, 2023
Yury-Fridlyand
approved these changes
Jun 15, 2023
| } | ||
|
|
||
| // Queries with LIMIT clause are not supported | ||
| // Queries with LIMIT/OFFSET clauses are unsupported |
There was a problem hiding this comment.
Suggested change
| // Queries with LIMIT/OFFSET clauses are unsupported | |
| // Queries with LIMIT and OFFSET clauses are unsupported |
Using a slash could imply LIMIT or OFFSET, rather than LIMIT and OFFSET, this will make things clearer
There was a problem hiding this comment.
Good idea, but it has to be applied on the original PR #1599
My next PR adds support for LIMIT, so only OFFSET remains unsupported without any ambiguity
matthewryanwells
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 94d5479 from #1599