Update docs for pagination. #1592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <[email protected]>
Codecov Report
@@ Coverage Diff @@
## feature/pagination/integ #1592 +/- ##
===========================================================
Coverage 97.23% 97.23%
Complexity 4233 4233
===========================================================
Files 387 387
Lines 10628 10628
Branches 721 721
===========================================================
Hits 10334 10334
Misses 287 287
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. |
acarbonetto
reviewed
Apr 28, 2023
Signed-off-by: Yury-Fridlyand <[email protected]>
|
Thanks @acarbonetto for your review. I addressed most of your comments. There are upcoming changes for merging index scans and removing total hits - those are not yet reflected in docs. |
Yury-Fridlyand
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az and
MaxKsyunz
as code owners
Signed-off-by: Yury-Fridlyand <[email protected]>
dai-chen
approved these changes
May 3, 2023
rupal-bq
approved these changes
May 3, 2023
MaxKsyunz
approved these changes
May 4, 2023
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
GumpacG
approved these changes
May 9, 2023
matthewryanwells
approved these changes
May 9, 2023
matthewryanwells
approved these changes
May 9, 2023
acarbonetto
approved these changes
May 9, 2023
| SecondPageTree --> SecondPage : Execution\nPreparation | ||
| ``` | ||
|
|
||
| #### Serialization |
There was a problem hiding this comment.
Not mentioned here (although maybe we should):
- What about the request context (like the query start time clock) - how is this serialized
- What about other request artefacts, such as
fetch_sizeor maybe thefilter- if provided. How do these translate from request-to-request? - Does this work with post-request processing?
- What about requests larger than the max window size of 10,000?
There was a problem hiding this comment.
- It is not supported yet, but actually it is just binary dumped into cursor
- It is not supported
- What do you mean?
- Good idea, I'll add
There was a problem hiding this comment.
Anything that we know is not-supported should be mentioned.
Yury-Fridlyand
commented
May 11, 2023
Co-authored-by: Andrew Carbonetto <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]>
Co-authored-by: Andrew Carbonetto <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add docs for pagination feature.
Keeping this as a draft, because there are some upcoming changes. Reviews and discussions are welcome though.
Note:
query-optimizer-improvement.mdwasn't deleted and recreated, just renamed and changed.Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.