Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE for SHOW statement without filter #150

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Fix NPE for SHOW statement without filter #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/src/main/antlr/OpenSearchSQLParser.g4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ adminStatement
;

showStatement
: SHOW TABLES tableFilter?
: SHOW TABLES tableFilter
;

describeStatement
Expand Down
5 changes: 5 additions & 0 deletions sql/src/test/java/org/opensearch/sql/sql/antlr/SQLSyntaxParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,4 +160,9 @@ public void canParseOrderByClause() {
"SELECT name, age FROM test ORDER BY name ASC NULLS FIRST, age DESC NULLS LAST"));
}

@Test
public void canNotParseShowStatementWithoutFilterClause() {
assertThrows(SyntaxCheckException.class, () -> parser.parse("SHOW TABLES"));
}

}