-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address build failures #1366
Address build failures #1366
Conversation
Signed-off-by: MaxKsyunz <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks Max
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose to wait for ml-commons
, then restart CI, then merge.
Signed-off-by: MaxKsyunz <[email protected]>
bc7d74c
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1366 +/- ##
============================================
- Coverage 99.96% 98.38% -1.58%
- Complexity 2464 3693 +1229
============================================
Files 220 343 +123
Lines 5833 9107 +3274
Branches 359 585 +226
============================================
+ Hits 5831 8960 +3129
- Misses 2 142 +140
- Partials 0 5 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: MaxKsyunz <[email protected]>
38d03f5
It is still used in the opensearch project. So add it back in case some opensearch-sepcific dependency ends up their. Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
|
...g/opensearch/sql/opensearch/storage/script/aggregation/dsl/BucketAggregationBuilderTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: MaxKsyunz <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1366-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cd95bc54140efbf8fc60932249f645dc581260e5
# Push it to GitHub
git push --set-upstream origin backport/backport-1366-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
I think no backport to 2.x is needed. |
Xcontent classes were moved in this PR opensearch-project/OpenSearch#5902 causing builds to fail. --------- Signed-off-by: MaxKsyunz <[email protected]>
Xcontent classes were moved in this PR opensearch-project/OpenSearch#5902 causing builds to fail. --------- Signed-off-by: MaxKsyunz <[email protected]>
Xcontent classes were moved in this PR opensearch-project/OpenSearch#5902 causing builds to fail. --------- Signed-off-by: MaxKsyunz <[email protected]>
Xcontent classes were moved in this PR opensearch-project/OpenSearch#5902 causing builds to fail. --------- Signed-off-by: MaxKsyunz <[email protected]> Signed-off-by: Matthew Wells <[email protected]>
Xcontent classes were moved in this PR opensearch-project/OpenSearch#5902 causing builds to fail. --------- Signed-off-by: MaxKsyunz <[email protected]> (cherry picked from commit cd95bc5)
Xcontent classes were moved in this PR opensearch-project/OpenSearch#5902 causing builds to fail. --------- Signed-off-by: MaxKsyunz <[email protected]> (cherry picked from commit cd95bc5)
* Address build failures (#1366) Xcontent classes were moved in this PR opensearch-project/OpenSearch#5902 causing builds to fail. Signed-off-by: MaxKsyunz <[email protected]>
This reverts commit cd95bc5.
Xcontent classes were moved in this PR opensearch-project/OpenSearch#5902 causing builds to fail.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.