-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Refactor OpenSearchQueryRequest and OpenSearchScrollRequest so that we pass in includes
list from query
#1536
Labels
maintenance
Improves code quality, but not the product
Comments
dai-chen
added
maintenance
Improves code quality, but not the product
and removed
enhancement
New feature or request
untriaged
labels
Apr 17, 2023
acarbonetto
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this issue
Aug 2, 2023
…ldues to builder Signed-off-by: acarbonetto <[email protected]>
This was referenced Aug 2, 2023
acarbonetto
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this issue
Aug 3, 2023
Signed-off-by: acarbonetto <[email protected]>
acarbonetto
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this issue
Aug 3, 2023
Signed-off-by: acarbonetto <[email protected]>
acarbonetto
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this issue
Aug 4, 2023
…ludes to builder (#320) * opensearch-project#1536: Refactor OpenSearchQueryRequest and move incldues to builder Signed-off-by: acarbonetto <[email protected]> * opensearch-project#1536: Checkstyle fixes Signed-off-by: acarbonetto <[email protected]> * opensearch-project#1536: Checkstyle fixes Signed-off-by: acarbonetto <[email protected]> --------- Signed-off-by: acarbonetto <[email protected]>
6 tasks
acarbonetto
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this issue
Aug 4, 2023
…ludes to builder (#320) * opensearch-project#1536: Refactor OpenSearchQueryRequest and move incldues to builder Signed-off-by: acarbonetto <[email protected]> * opensearch-project#1536: Checkstyle fixes Signed-off-by: acarbonetto <[email protected]> * opensearch-project#1536: Checkstyle fixes Signed-off-by: acarbonetto <[email protected]> --------- Signed-off-by: acarbonetto <[email protected]>
6 tasks
acarbonetto
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this issue
Aug 9, 2023
Signed-off-by: acarbonetto <[email protected]>
Yury-Fridlyand
pushed a commit
that referenced
this issue
Aug 9, 2023
…1937) * #1536: Refactor OpenSearchQueryRequest and move includes to builder (#320) * #1536: Refactor OpenSearchQueryRequest and move incldues to builder Signed-off-by: acarbonetto <[email protected]> * #1536: Checkstyle fixes Signed-off-by: acarbonetto <[email protected]> * #1536: Checkstyle fixes Signed-off-by: acarbonetto <[email protected]> --------- Signed-off-by: acarbonetto <[email protected]> * #1536: Spotless Apply Signed-off-by: acarbonetto <[email protected]> --------- Signed-off-by: acarbonetto <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this issue
Aug 9, 2023
…1937) * #1536: Refactor OpenSearchQueryRequest and move includes to builder (#320) * #1536: Refactor OpenSearchQueryRequest and move incldues to builder Signed-off-by: acarbonetto <[email protected]> * #1536: Checkstyle fixes Signed-off-by: acarbonetto <[email protected]> * #1536: Checkstyle fixes Signed-off-by: acarbonetto <[email protected]> --------- Signed-off-by: acarbonetto <[email protected]> * #1536: Spotless Apply Signed-off-by: acarbonetto <[email protected]> --------- Signed-off-by: acarbonetto <[email protected]> (cherry picked from commit 7d23e0f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
GumpacG
pushed a commit
that referenced
this issue
Aug 10, 2023
…1937) (#1948) * #1536: Refactor OpenSearchQueryRequest and move includes to builder (#320) * #1536: Refactor OpenSearchQueryRequest and move incldues to builder * #1536: Checkstyle fixes * #1536: Checkstyle fixes --------- * #1536: Spotless Apply --------- (cherry picked from commit 7d23e0f) Signed-off-by: acarbonetto <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
MitchellGale
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this issue
Aug 14, 2023
…cludes to builder (opensearch-project#1937) * opensearch-project#1536: Refactor OpenSearchQueryRequest and move includes to builder (#320) * opensearch-project#1536: Refactor OpenSearchQueryRequest and move incldues to builder Signed-off-by: acarbonetto <[email protected]> * opensearch-project#1536: Checkstyle fixes Signed-off-by: acarbonetto <[email protected]> * opensearch-project#1536: Checkstyle fixes Signed-off-by: acarbonetto <[email protected]> --------- Signed-off-by: acarbonetto <[email protected]> * opensearch-project#1536: Spotless Apply Signed-off-by: acarbonetto <[email protected]> --------- Signed-off-by: acarbonetto <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem?
When creating the OpenSearchResponse, we don't have access to the OpenSearchQueryRequest or OpenSearchScrollRequest - which is needed for context. Right now, we are picking out the
includes
list but this is unavailable for scroll requests (which means_id
and other metafields are not output on 2+ pages of pagination requests).What solution would you like?
What alternatives have you considered?
Related to changes in #1456
Do you have any additional context?
N/A
The text was updated successfully, but these errors were encountered: