Change grammar and add UT

Signed-off-by: Chen Dai <[email protected]>
opensearch-project · Jun 30, 2021 · b23c4a5 · b23c4a5
1 parent 47f5534
commit b23c4a5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/sql/src/main/antlr/OpenSearchSQLParser.g4 b/sql/src/main/antlr/OpenSearchSQLParser.g4
@@ -72,7 +72,7 @@ adminStatement
     ;
 
 showStatement
-    : SHOW TABLES tableFilter?
+    : SHOW TABLES tableFilter
     ;
 
 describeStatement

diff --git a/sql/src/test/java/org/opensearch/sql/sql/antlr/SQLSyntaxParserTest.java b/sql/src/test/java/org/opensearch/sql/sql/antlr/SQLSyntaxParserTest.java
@@ -160,4 +160,9 @@ public void canParseOrderByClause() {
         "SELECT name, age FROM test ORDER BY name ASC NULLS FIRST, age DESC NULLS LAST"));
   }
 
+  @Test
+  public void canNotParseShowStatementWithoutFilterClause() {
+    assertThrows(SyntaxCheckException.class, () -> parser.parse("SHOW TABLES"));
+  }
+
 }