Fix SparkExecutionEngineConfigClusterSetting deserialize issue

Signed-off-by: Tomoyuki Morita <[email protected]>
opensearch-project · Jul 17, 2024 · 4ae4566 · 4ae4566
1 parent a151a7d
commit 4ae4566
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/...c/main/java/org/opensearch/sql/spark/config/SparkExecutionEngineConfigClusterSetting.java b/...c/main/java/org/opensearch/sql/spark/config/SparkExecutionEngineConfigClusterSetting.java
@@ -6,8 +6,10 @@
 package org.opensearch.sql.spark.config;
 
 import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
+import lombok.AllArgsConstructor;
 import lombok.Builder;
 import lombok.Data;
+import lombok.NoArgsConstructor;
 import org.opensearch.sql.utils.SerializeUtils;
 
 /**
@@ -16,6 +18,8 @@
  */
 @Data
 @Builder
+@AllArgsConstructor
+@NoArgsConstructor
 @JsonIgnoreProperties(ignoreUnknown = true)
 public class SparkExecutionEngineConfigClusterSetting {
   // optional

diff --git a/...st/java/org/opensearch/sql/spark/config/SparkExecutionEngineConfigClusterSettingTest.java b/...st/java/org/opensearch/sql/spark/config/SparkExecutionEngineConfigClusterSettingTest.java
@@ -46,4 +46,18 @@ public void testToSparkExecutionEngineConfigWithAllFields() {
     assertEquals("us-west-1", config.getRegion());
     assertEquals("--conf A=1", config.getSparkSubmitParameters());
   }
+
+  @Test
+  public void testToSparkExecutionEngineConfigWithNoFields() {
+    String json = "{}";
+
+    SparkExecutionEngineConfigClusterSetting config =
+        SparkExecutionEngineConfigClusterSetting.toSparkExecutionEngineConfig(json);
+
+    assertNull(config.getApplicationId());
+    assertNull(config.getExecutionRoleARN());
+    assertNull(config.getRegion());
+    assertNull(config.getSparkSubmitParameters());
+  }
+
 }