Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#74 - Fix failing build-mac pipeline job #77

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

currantw
Copy link
Contributor

Description

Fixes failing build-mac pipeline job.

Issues Resolved

#74

Check List

  • [N/A] New functionality includes testing.
  • All tests pass, including unit test, integration test and doctest
  • [N/A] New functionality has been documented.
  • [N/A] New functionality has javadoc added
  • [N/A] New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

run_cppcheck.sh Show resolved Hide resolved
src/opensearchenlist/msdtc_enlist.cpp Show resolved Hide resolved
@currantw currantw changed the title Initial implementation to fix errors. #74 - Fix failing build-mac pipeline job Nov 20, 2024
Copy link
Collaborator

@MaxKsyunz MaxKsyunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for cleaning this up!

run_cppcheck.sh Outdated Show resolved Hide resolved
@currantw
Copy link
Contributor Author

Note: Created another related issue to fix the failing linkchecker job.

@acarbonetto acarbonetto merged commit 4259943 into opensearch-project:main Nov 25, 2024
6 of 8 checks passed
@acarbonetto acarbonetto deleted the AOS-2314_cppcheck branch November 25, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants