Bump version and update vendor. #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz and
anirudha
as code owners
|
Tested on Windows: |
| </CPackWiXPatch> |
There was a problem hiding this comment.
Should this file end with a whitespace?
There was a problem hiding this comment.
All files should end with a blank line
acarbonetto
approved these changes
Jun 2, 2023
matthewryanwells
approved these changes
Jun 2, 2023
MaxKsyunz
reviewed
Jun 13, 2023
| @@ -1,7 +1,7 @@ | |||
| <CPackWiXPatch> | |||
| <CPackWiXFragment Id="CM_CP_Driver.bin.sqlodbc.dll"> | |||
| <!-- Add driver entry in Software --> | |||
| <RegistryKey Root="HKLM" Key="SOFTWARE\Amazon\OpenSearch SQL ODBC Driver\Driver" > | |||
| <RegistryKey Root="HKLM" Key="SOFTWARE\OpenSearch Project\OpenSearch SQL ODBC Driver\Driver" > | |||
There was a problem hiding this comment.
How will this affect upgrading from 1.3.0.0?
As I see it, if the user has custom values set up, say LogLevel or LogOutput, they will be lost.
There was a problem hiding this comment.
Oh yes, it is a very good point.
Unfortunately, current installer does not support upgrade, so user has to delete old version first (which cleans up registry entries) and install new. These settings are always lost, unless installer reworked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump version and update vendor.
I also cleaned up some dangling whitespaces.
Issues Resolved
Release preparation.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.