Add new parameter for SIGv4 auth. #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <[email protected]>
acarbonetto
approved these changes
May 12, 2023
|
Make sure to update documentation for connections and mention how to connect basic/sigv4 through a tunnel (and what to set as the tunnel host): https://github.com/opensearch-project/sql-odbc/blob/main/docs/user/configuration_options.md |
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
commented
May 19, 2023
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz and
anirudha
as code owners
matthewryanwells
approved these changes
May 23, 2023
dai-chen
approved these changes
May 23, 2023
GumpacG
approved these changes
May 23, 2023
dylanmtaylor
approved these changes
May 26, 2023
This was referenced Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new optional parameter for use with AWS_SIGv4 authentication to connect to a cluster via SSH tunnel (for example - OpenSearch cluster is a VPC endpoint).
This parameter is required to fix request header to comply SIGv4 requirements. Ref: link.
New UI config parameter + new connection string parameter:
TODOs
Issues Resolved
Fixes #41, #39
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.