-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LogPatternTool (#413) #418
Merged
xinyual
merged 3 commits into
opensearch-project:2.x
from
qianheng-aws:backport/backport-413-to-2.x
Sep 29, 2024
Merged
Add LogPatternTool (#413) #418
xinyual
merged 3 commits into
opensearch-project:2.x
from
qianheng-aws:backport/backport-413-to-2.x
Sep 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ut fix: construct update in Monitor Signed-off-by: Heng Qian <[email protected]> * Add LogPatternTool Signed-off-by: Heng Qian <[email protected]> * Address comments Signed-off-by: Heng Qian <[email protected]> * Add function doc Signed-off-by: Heng Qian <[email protected]> * Address comments Signed-off-by: Heng Qian <[email protected]> * Address comments Signed-off-by: Heng Qian <[email protected]> --------- Signed-off-by: Heng Qian <[email protected]> (cherry picked from commit 7d72612)
qianheng-aws
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
xinyual,
amitgalitz,
jackiehanyang,
owaiskazi19,
ohltyler,
joshpalis,
dbwiddis,
kaituo,
lezzago,
eirsep,
sbcd90 and
zhichao-aws
as code owners
September 29, 2024 10:02
xinyual
approved these changes
Sep 29, 2024
model-collapse
approved these changes
Sep 29, 2024
Signed-off-by: Heng Qian <[email protected]>
Signed-off-by: Heng Qian <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #418 +/- ##
============================================
- Coverage 81.63% 77.67% -3.97%
- Complexity 221 235 +14
============================================
Files 13 14 +1
Lines 1122 1241 +119
Branches 161 179 +18
============================================
+ Hits 916 964 +48
- Misses 144 208 +64
- Partials 62 69 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
qianheng-aws
added a commit
to qianheng-aws/skills
that referenced
this pull request
Oct 10, 2024
* Add LogPatternTool (opensearch-project#413) * ut fix: construct update in Monitor Signed-off-by: Heng Qian <[email protected]> * Add LogPatternTool Signed-off-by: Heng Qian <[email protected]> * Address comments Signed-off-by: Heng Qian <[email protected]> * Add function doc Signed-off-by: Heng Qian <[email protected]> * Address comments Signed-off-by: Heng Qian <[email protected]> * Address comments Signed-off-by: Heng Qian <[email protected]> --------- Signed-off-by: Heng Qian <[email protected]> (cherry picked from commit 7d72612) * Make compatible with java11 Signed-off-by: Heng Qian <[email protected]> * spotlessApply Signed-off-by: Heng Qian <[email protected]> --------- Signed-off-by: Heng Qian <[email protected]>
xinyual
pushed a commit
that referenced
this pull request
Oct 10, 2024
* Add LogPatternTool (#413) * ut fix: construct update in Monitor * Add LogPatternTool * Address comments * Add function doc * Address comments * Address comments --------- (cherry picked from commit 7d72612) * Make compatible with java11 * spotlessApply --------- Signed-off-by: Heng Qian <[email protected]>
qianheng-aws
added a commit
to qianheng-aws/skills
that referenced
this pull request
Oct 12, 2024
…ct#418) (opensearch-project#422)" This reverts commit 7cd2c22.
qianheng-aws
added a commit
to qianheng-aws/skills
that referenced
this pull request
Oct 12, 2024
…ct#418) (opensearch-project#422)" This reverts commit 7cd2c22. Signed-off-by: Heng Qian <[email protected]>
xinyual
pushed a commit
that referenced
this pull request
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport/backport 413 to 2.x
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.