Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LogPatternTool (#413) #418

Merged

Conversation

qianheng-aws
Copy link
Contributor

@qianheng-aws qianheng-aws commented Sep 29, 2024

Description

Backport/backport 413 to 2.x

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* ut fix: construct update in Monitor

Signed-off-by: Heng Qian <[email protected]>

* Add LogPatternTool

Signed-off-by: Heng Qian <[email protected]>

* Address comments

Signed-off-by: Heng Qian <[email protected]>

* Add function doc

Signed-off-by: Heng Qian <[email protected]>

* Address comments

Signed-off-by: Heng Qian <[email protected]>

* Address comments

Signed-off-by: Heng Qian <[email protected]>

---------

Signed-off-by: Heng Qian <[email protected]>
(cherry picked from commit 7d72612)
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 40.98361% with 72 lines in your changes missing coverage. Please review.

Project coverage is 77.67%. Comparing base (3cbb1f4) to head (3aa759d).
Report is 6 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ava/org/opensearch/agent/tools/LogPatternTool.java 41.52% 62 Missing and 7 partials ⚠️
src/main/java/org/opensearch/agent/ToolPlugin.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x     #418      +/-   ##
============================================
- Coverage     81.63%   77.67%   -3.97%     
- Complexity      221      235      +14     
============================================
  Files            13       14       +1     
  Lines          1122     1241     +119     
  Branches        161      179      +18     
============================================
+ Hits            916      964      +48     
- Misses          144      208      +64     
- Partials         62       69       +7     
Flag Coverage Δ
77.67% <40.98%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xinyual xinyual merged commit a26c924 into opensearch-project:2.x Sep 29, 2024
14 of 18 checks passed
qianheng-aws added a commit to qianheng-aws/skills that referenced this pull request Oct 10, 2024
* Add LogPatternTool (opensearch-project#413)

* ut fix: construct update in Monitor

Signed-off-by: Heng Qian <[email protected]>

* Add LogPatternTool

Signed-off-by: Heng Qian <[email protected]>

* Address comments

Signed-off-by: Heng Qian <[email protected]>

* Add function doc

Signed-off-by: Heng Qian <[email protected]>

* Address comments

Signed-off-by: Heng Qian <[email protected]>

* Address comments

Signed-off-by: Heng Qian <[email protected]>

---------

Signed-off-by: Heng Qian <[email protected]>
(cherry picked from commit 7d72612)

* Make compatible with java11

Signed-off-by: Heng Qian <[email protected]>

* spotlessApply

Signed-off-by: Heng Qian <[email protected]>

---------

Signed-off-by: Heng Qian <[email protected]>
xinyual pushed a commit that referenced this pull request Oct 10, 2024
* Add LogPatternTool (#413)

* ut fix: construct update in Monitor



* Add LogPatternTool



* Address comments



* Add function doc



* Address comments



* Address comments



---------


(cherry picked from commit 7d72612)

* Make compatible with java11



* spotlessApply



---------

Signed-off-by: Heng Qian <[email protected]>
qianheng-aws added a commit to qianheng-aws/skills that referenced this pull request Oct 12, 2024
xinyual added a commit that referenced this pull request Oct 12, 2024
qianheng-aws added a commit to qianheng-aws/skills that referenced this pull request Oct 12, 2024
xinyual pushed a commit that referenced this pull request Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants