Add cluster setting to control ppl execution #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zane-neo
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
Zhangxunmt,
xinyual,
amitgalitz,
jackiehanyang,
owaiskazi19,
ohltyler,
joshpalis,
dbwiddis,
kaituo,
lezzago,
eirsep,
sbcd90,
zhichao-aws and
joshuali925
as code owners
|
We already have a Tool level execution controller, why we need a cluster level one? Is this for OASIS? |
Yes, in serverless currently the ppl execution will be disabled by default. |
xinyual
reviewed
Jul 3, 2024
| @@ -227,7 +226,7 @@ public <T> void run(Map<String, String> parameters, ActionListener<T> listener) | |||
| return; | |||
| } | |||
| String ppl = parseOutput(dataAsMap.get("response"), indexName); | |||
| if (!this.execute) { | |||
| if (!clusterSettingHelper.getClusterSettings(SkillSettings.PPL_EXECUTION_ENABLED) || !this.execute) { | |||
| Map<String, String> ret = ImmutableMap.of("ppl", ppl); | |||
There was a problem hiding this comment.
Can we add a log here when cluster setting and tool setting are conflict? For example, "To execute PPL, please set lugins.skills.ppl_execution_enabled to true". It may be confused if customer set tool setting to true but it is not executed.
There was a problem hiding this comment.
Sure, will add debug log here.
xinyual
approved these changes
Jul 10, 2024
Signed-off-by: zane-neo <[email protected]>
Signed-off-by: zane-neo <[email protected]>
Signed-off-by: zane-neo <[email protected]>
Signed-off-by: zane-neo <[email protected]>
Signed-off-by: zane-neo <[email protected]>
zane-neo
force-pushed
the
ppl-execution-setting
branch
from
6fb5979
to
4622091
Compare
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Add cluster setting to control ppl execution Signed-off-by: zane-neo <[email protected]> * format code Signed-off-by: zane-neo <[email protected]> * format code Signed-off-by: zane-neo <[email protected]> * Add debug log to indicate the ppl execution settings Signed-off-by: zane-neo <[email protected]> * format code Signed-off-by: zane-neo <[email protected]> --------- Signed-off-by: zane-neo <[email protected]> (cherry picked from commit 14d9ef2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zane-neo
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Add cluster setting to control ppl execution * format code * format code * Add debug log to indicate the ppl execution settings * format code --------- (cherry picked from commit 14d9ef2) Signed-off-by: zane-neo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
74 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add cluster setting to control ppl execution
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.