-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Netty4 header verifier inbound handler to deal with upgrade requests #5045
Conversation
Signed-off-by: Andriy Redko <[email protected]>
d9f709b
to
b98110a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5045 +/- ##
==========================================
- Coverage 71.50% 71.46% -0.04%
==========================================
Files 336 336
Lines 22617 22617
Branches 3599 3599
==========================================
- Hits 16172 16163 -9
- Misses 4644 4652 +8
- Partials 1801 1802 +1
|
Should the changes in |
I think it would be a good idea, for 3.x / 2.x mixed clusters that would be helpful, thanks @cwperks |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-5045-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2bef10c8754cd40754fc1dbc72a82b0dece25c9b
# Push it to GitHub
git push --set-upstream origin backport/backport-5045-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.x Then, create a pull request where the |
…sts (opensearch-project#5045) Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 2bef10c)
Description
Fix Netty4 header verifier inbound handler to deal with upgrade requests
Issues Resolved
Follow up on #5035
Testing
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.