Always retry integrationTest unless explicitly disabled with DISABLE_RETRY #4853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RETRY Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
DarshitChanpura,
derek-ho,
nibix,
peternied,
RyanL1997,
reta and
willyborankin
as code owners
willyborankin
approved these changes
Oct 28, 2024
derek-ho
approved these changes
Oct 28, 2024
willyborankin
merged commit cdfd41e
into
opensearch-project:main
43 of 44 checks passed
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 28, 2024
…RETRY (#4853) Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit cdfd41e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 28, 2024
…RETRY (#4853) Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit cdfd41e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the retry logic for the integrationTest task. Currently, it will only apply the retry logic if
CI_ENVIRONMENTis set tonormal. This PR changes this so that the retry logic is always applied, but can be disable through setting an env variable. You can disable tests withDISABLE_RETRY=trueFor example:
This PR is related to #4816 where the integrationTests are not being retried in the release testing workflow since
CI_ENVIRONMENTis not set.Test fix
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.