-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nils Bandener (Github: nibix) as a maintainer #4672
Conversation
Signed-off-by: Craig Perkins <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nibix well deserved!
@opensearch-project/admin Could we have the repo permissions updated to include @nibix as a new maintainer? |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/security/backport-1.3
# Create a new branch
git switch --create backport/backport-4672-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a7ef02e421aa8eb634654d2a7ed5c2ec7a1c4b65
# Push it to GitHub
git push --set-upstream origin backport/backport-4672-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-1.3 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-4672-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a7ef02e421aa8eb634654d2a7ed5c2ec7a1c4b65
# Push it to GitHub
git push --set-upstream origin backport/backport-4672-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-1.x
# Create a new branch
git switch --create backport/backport-4672-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a7ef02e421aa8eb634654d2a7ed5c2ec7a1c4b65
# Push it to GitHub
git push --set-upstream origin backport/backport-4672-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-1.x Then, create a pull request where the |
@cwperks Could you take care of the backports conflicts? |
Sure. |
…#4672) Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit a7ef02e)
Thank you so much. Feeling honored! 😊 |
Welcome aboard @nibix! No takesy-backsies |
I have nominated, and maintainers have agreed to add Nils Bandener (@nibix) as a co-maintainer, who has kindly accepted.
Nils has made many valuable contributions and given insight into the OpenSearch Security repo over the last few years.
Notable code contributions from Nils include:
Nils has engaged in maintenance of the code base like fixing flaky tests and bug fixes as well. Here are some examples:
See all code contributions (Open + Closed) from Nils here: https://github.com/opensearch-project/security/pulls?q=is%3Apr+author%3Anibix
Nils has also contributed valuable insight on many occasions including submission of 5 RFCs:
Nils regularly contributes to conversation on Pull Requests, RFCs and other issues:
See all PRs where Nils has engaged as a commenter: https://github.com/opensearch-project/security/pulls?q=is%3Apr+commenter%3Anibix
See all issues where Nils has engaged as a commenter: https://github.com/opensearch-project/security/issues?q=is%3Aissue+commenter%3Anibix
Additionally, Nils is active in the community and has given a talk at OpenSearch Con EU: https://opensearch.org/community/members/nbendener.html