Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependancy Apache CXF #4580

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Jul 18, 2024

Description

Since 2.12, the JWT implementation used in the SAML flow changed from Apache CXF to Nimbus. The PR where the change occurred is #3421

I'm opening a PR on main and 2.x to remove the remaining references to CXF and a separate PR on the 1.x line to update the dependencies which are still in use on that line.

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Maintenance

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <[email protected]>
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.28%. Comparing base (32bcf7b) to head (2710d89).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4580      +/-   ##
==========================================
+ Coverage   65.25%   65.28%   +0.03%     
==========================================
  Files         317      317              
  Lines       22272    22272              
  Branches     3582     3582              
==========================================
+ Hits        14534    14541       +7     
+ Misses       5946     5939       -7     
  Partials     1792     1792              

see 1 file with indirect coverage changes

@peternied peternied changed the title Remove apache cxf on main and 2.x Remove unused dependancy Apache CXF Jul 18, 2024
@peternied peternied merged commit 26a4c0b into opensearch-project:main Jul 18, 2024
41 of 42 checks passed
@peternied peternied added the backport 2.x backport to 2.x branch label Jul 18, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 18, 2024
(cherry picked from commit 26a4c0b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants