Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Typo in securityadmin.sh hint #4526

Merged

Conversation

prabhask5
Copy link
Contributor

@prabhask5 prabhask5 commented Jul 5, 2024

Description

Fixed typo in "Try running securityadmin.sh with -icl (but no -cl) and -nhnv (If that works you need to check your clustername as well as hostnames in your TLS certificates)", changed -cl to -cn as per: #4376

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
    Bug fix

  • Why these changes are required?
    -cl does not exist, so it was changed to the correct -cn

  • What is the old behavior before changes and new behavior after changes?
    Nothing ideally

Issues Resolved

#4376

Is this a backport? If so, please add backport PR # and/or commits #
No

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Prabhas Kurapati <[email protected]>
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.18%. Comparing base (20c8775) to head (5695d51).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4526      +/-   ##
==========================================
- Coverage   65.22%   65.18%   -0.05%     
==========================================
  Files         313      313              
  Lines       22053    22053              
  Branches     3561     3561              
==========================================
- Hits        14385    14376       -9     
- Misses       5895     5903       +8     
- Partials     1773     1774       +1     
Files Coverage Δ
...a/org/opensearch/security/tools/SecurityAdmin.java 44.39% <ø> (ø)

... and 4 files with indirect coverage changes

@cwperks cwperks added the backport 2.x backport to 2.x branch label Jul 5, 2024
@cwperks cwperks merged commit 0a91626 into opensearch-project:main Jul 5, 2024
42 of 43 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 5, 2024
Signed-off-by: Prabhas Kurapati <[email protected]>
(cherry picked from commit 0a91626)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@prabhask5 prabhask5 deleted the pk-fix-securityadmin-typo branch July 10, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants