Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set security plugin 3.0.0 baseline JDK version to JDK-21 #4457

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented Jun 13, 2024

Description

Set security plugin 3.0.0 baseline JDK version to JDK-21

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
  • Why these changes are required?
  • What is the old behavior before changes and new behavior after changes?

Issues Resolved

Closes #4407

Testing

N/A

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

willyborankin
willyborankin previously approved these changes Jun 13, 2024
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.24%. Comparing base (681a944) to head (3e8a93d).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4457      +/-   ##
==========================================
- Coverage   65.43%   65.24%   -0.20%     
==========================================
  Files         312      312              
  Lines       22037    22032       -5     
  Branches     3557     3558       +1     
==========================================
- Hits        14421    14375      -46     
- Misses       5843     5888      +45     
+ Partials     1773     1769       -4     
Files Coverage Δ
...mazon/dlic/auth/http/jwt/HTTPJwtAuthenticator.java 73.58% <ø> (ø)
...ic/auth/http/kerberos/HTTPSpnegoAuthenticator.java 0.00% <ø> (ø)
...a/org/opensearch/security/DefaultObjectMapper.java 65.97% <ø> (ø)
...ecurity/configuration/ConfigurationRepository.java 72.51% <ø> (ø)
...security/dlic/rest/api/ConfigUpgradeApiAction.java 72.97% <ø> (ø)
...ensearch/security/hasher/BCryptPasswordHasher.java 85.71% <ø> (ø)
...nsearch/security/http/OnBehalfOfAuthenticator.java 91.34% <ø> (ø)
...ch/security/securityconf/DynamicConfigModelV7.java 61.14% <ø> (ø)
...ensearch/security/ssl/DefaultSecurityKeyStore.java 66.53% <ø> (-7.20%) ⬇️
.../org/opensearch/security/support/ConfigHelper.java 88.46% <ø> (ø)
... and 2 more

... and 7 files with indirect coverage changes

@reta
Copy link
Collaborator Author

reta commented Jun 13, 2024

Seems like the GA cannot be changed at the same time as JDK baseline, opening #4461 The assumption was wrong, needs derek-ho/start-opensearch#6 first

@reta reta force-pushed the issue-4407 branch 4 times, most recently from a0e48d7 to 611334a Compare June 13, 2024 20:17
@reta
Copy link
Collaborator Author

reta commented Jun 14, 2024

@peternied @cwperks @scrawfor99 folks could you please help to review? there are changes in Github branch checks that needs this pull request in. Thank you.

@cwperks
Copy link
Member

cwperks commented Jun 14, 2024

@reta I'm not able to re-run the CI checks that are stuck. You may need to push a change to get the CI checks to re-run.

@reta
Copy link
Collaborator Author

reta commented Jun 14, 2024

@reta I'm not able to re-run the CI checks that are stuck. You may need to push a change to get the CI checks to re-run.

Yes, taking to @gaiksaya , thanks @cwperks !

@willyborankin
Copy link
Collaborator

willyborankin commented Jun 14, 2024

@reta I'm not able to re-run the CI checks that are stuck. You may need to push a change to get the CI checks to re-run.

They were created by me in PR which I closed. I'm wondering why they appeared in all PRs :-)

@reta
Copy link
Collaborator Author

reta commented Jun 14, 2024

They were created by me in PR which I closed. I'm wondering why they appeared in all PRs :-)

These checks are configured in repo settings, asked to remove them for now

@willyborankin
Copy link
Collaborator

willyborankin commented Jun 14, 2024

@reta I'm not able to re-run the CI checks that are stuck. You may need to push a change to get the CI checks to re-run.

They were created by me in PR which I closed. I'm wondering why they appeared in all PRs :-)

I got it why.

@willyborankin
Copy link
Collaborator

They were created by me in PR which I closed. I'm wondering why they appeared in all PRs :-)

These checks are configured in repo settings, asked to remove them for now

We do not need them. It was an experiment.

@cwperks cwperks merged commit 439606c into opensearch-project:main Jun 14, 2024
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Set security plugin 3.0.0 baseline JDK version to JDK-21
3 participants