Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3] Bump bouncycastle to 1.78.1 and kafka to 3.7.0 #4437

Merged
merged 8 commits into from
Jun 13, 2024

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Jun 11, 2024

Description

Bump bouncycastle from 1.75 to 1.78.1 and kafka to 3.7.0

  • Category

Maintenance

Issues Resolved

Resolves Whitesource issues seen in the 1.3.18 version bump: https://github.com/opensearch-project/security/pull/4415/checks?check_run_id=25964867842

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

willyborankin
willyborankin previously approved these changes Jun 11, 2024
@willyborankin
Copy link
Collaborator

willyborankin commented Jun 11, 2024

@cwperks you need to change *.policy file for the new BC version:

  // BouncyCastle permissions
  permission java.security.SecurityPermission "putProviderProperty.BC";
  permission java.security.SecurityPermission "insertProvider.BC";
  permission java.security.SecurityPermission "removeProviderProperty.BC";
  permission java.security.SecurityPermission "getProperty.org.bouncycastle.ec.max_f2m_field_size";
  permission java.security.SecurityPermission "getProperty.org.bouncycastle.pkcs12.default";
  permission java.security.SecurityPermission "getProperty.org.bouncycastle.rsa.max_size";
  permission java.security.SecurityPermission "getProperty.org.bouncycastle.rsa.max_mr_tests";

@cwperks
Copy link
Member Author

cwperks commented Jun 12, 2024

@willyborankin Thanks for catching that! Update the plugin-security.policy file.

build.gradle Outdated Show resolved Hide resolved
Signed-off-by: Craig Perkins <[email protected]>
@cwperks cwperks changed the title [1.3] Bump bouncycastle to 1.78 and kafka to 3.6.2 [1.3] Bump bouncycastle to 1.78.1 and kafka to 3.6.2 Jun 12, 2024
Signed-off-by: Craig Perkins <[email protected]>
@cwperks cwperks changed the title [1.3] Bump bouncycastle to 1.78.1 and kafka to 3.6.2 [1.3] Bump bouncycastle to 1.78.1 and kafka to 3.7.0 Jun 12, 2024
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Copy link
Member Author

cwperks commented Jun 12, 2024

Backported an additional commit from #4087 to include kafka-server to resolve a ClassNotFound error during upgrade.

ref: https://github.com/opensearch-project/security/actions/runs/9489776378/job/26151814321?pr=4437

willyborankin
willyborankin previously approved these changes Jun 12, 2024
reta
reta previously approved these changes Jun 12, 2024
@cwperks cwperks dismissed stale reviews from reta and willyborankin via 21002d9 June 13, 2024 00:14
@cwperks
Copy link
Member Author

cwperks commented Jun 13, 2024

Pushed another commit to bring in the dependencies introduced in https://github.com/opensearch-project/security/pull/3504/files

@reta reta merged commit 8b44076 into opensearch-project:1.3 Jun 13, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants