Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Replace BouncyCastle's OpenBSDBCrypt use with password4j for password hashing and verification #4428

Conversation

dancristiancecoi
Copy link
Contributor

Manual backport 20c524a from #4381.

Auto-merge failed due to slight differences in code between 2.x and main branches.

…d hashing and verification (opensearch-project#4381)

Signed-off-by: Dan Cecoi <[email protected]>
Co-authored-by: Dan Cecoi <[email protected]>
(cherry picked from commit 20c524a)
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 88.67925% with 6 lines in your changes missing coverage. Please review.

Project coverage is 65.37%. Comparing base (932bf72) to head (0039083).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x    #4428      +/-   ##
==========================================
+ Coverage   65.36%   65.37%   +0.01%     
==========================================
  Files         309      310       +1     
  Lines       21839    21866      +27     
  Branches     3547     3550       +3     
==========================================
+ Hits        14275    14295      +20     
- Misses       5802     5803       +1     
- Partials     1762     1768       +6     
Files Coverage Δ
.../opensearch/security/OpenSearchSecurityPlugin.java 84.35% <100.00%> (+0.04%) ⬆️
...y/auth/internal/InternalAuthenticationBackend.java 72.30% <100.00%> (+0.87%) ⬆️
...security/dlic/rest/api/InternalUsersApiAction.java 81.57% <100.00%> (+0.16%) ⬆️
...security/dlic/rest/api/SecurityRestApiActions.java 80.00% <ø> (ø)
...g/opensearch/security/dlic/rest/support/Utils.java 60.52% <ø> (-2.89%) ⬇️
...ch/security/securityconf/DynamicConfigFactory.java 54.85% <100.00%> (ø)
...ain/java/org/opensearch/security/tools/Hasher.java 6.06% <100.00%> (-10.16%) ⬇️
...y/tools/democonfig/SecuritySettingsConfigurer.java 76.71% <100.00%> (+0.32%) ⬆️
...earch/security/dlic/rest/api/AccountApiAction.java 60.56% <66.66%> (+0.56%) ⬆️
...java/org/opensearch/security/user/UserService.java 57.03% <80.00%> (+0.32%) ⬆️
... and 1 more

... and 3 files with indirect coverage changes

@willyborankin willyborankin merged commit 1a313f4 into opensearch-project:2.x Jun 10, 2024
78 checks passed
@dancristiancecoi dancristiancecoi deleted the backport/backport-4381-to-2.x branch June 12, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants