Add support for ipv6 ip address in user injection #4399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <[email protected]>
derek-ho
commented
Jun 3, 2024
src/test/java/org/opensearch/security/auth/UserInjectorTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Derek Ho <[email protected]>
derek-ho
requested review from
cliu123,
cwperks,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
derek-ho
commented
Jun 3, 2024
cwperks
reviewed
Jun 4, 2024
cwperks
reviewed
Jun 4, 2024
cwperks
reviewed
Jun 4, 2024
src/test/java/org/opensearch/security/auth/UserInjectorTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
shikharj05
reviewed
Jun 5, 2024
Signed-off-by: Derek Ho <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4399 +/- ##
==========================================
+ Coverage 65.39% 65.41% +0.01%
==========================================
Files 310 310
Lines 21993 21995 +2
Branches 3554 3554
==========================================
+ Hits 14383 14388 +5
+ Misses 5838 5835 -3
Partials 1772 1772
|
DarshitChanpura
approved these changes
Jun 5, 2024
cwperks
approved these changes
Jun 5, 2024
shikharj05
approved these changes
Jun 6, 2024
|
DCO check is stuck. I am bypassing and manually verified that all commits are signed. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 6, 2024
Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit fd6fb3f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enhances the parsing logic of user injection to support ipv6 addresses.
Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
Bug fix
Why these changes are required?
Issue: [BUG] User Injection is failing for IPV6 addresses #4177
What is the old behavior before changes and new behavior after changes?
Ipv6 IP addresses would throw a parsing error, now it doesn't
Issues Resolved
Fix: #4177
Is this a backport? If so, please add backport PR # and/or commits #
No
Testing
Added unit test
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.