-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ActionGroup REST API test and partial fix #4166 #4371
Refactor ActionGroup REST API test and partial fix #4166 #4371
Conversation
The test was moved into DefaultApiAvailabilityIntegrationTest Signed-off-by: Andrey Pleskach <[email protected]>
1bdb553
to
02f5e0f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4371 +/- ##
==========================================
- Coverage 65.43% 65.37% -0.06%
==========================================
Files 310 310
Lines 21992 21993 +1
Branches 3554 3554
==========================================
- Hits 14391 14379 -12
- Misses 5830 5842 +12
- Partials 1771 1772 +1
|
src/main/java/org/opensearch/security/dlic/rest/api/ActionGroupsApiAction.java
Show resolved
Hide resolved
src/integrationTest/java/org/opensearch/security/api/AbstractApiIntegrationTest.java
Show resolved
Hide resolved
src/integrationTest/java/org/opensearch/security/api/ActionGroupsRestApiIntegrationTest.java
Outdated
Show resolved
Hide resolved
src/integrationTest/java/org/opensearch/security/api/ActionGroupsRestApiIntegrationTest.java
Show resolved
Hide resolved
...integrationTest/java/org/opensearch/security/api/AbstractConfigEntityApiIntegrationTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrey Pleskach <[email protected]>
Changes: - Moved ActionGroupsApiTest into ActionGroupsRestApiIntegrationTest - Partially fixed issue opensearch-project#4166 for action groups only Signed-off-by: Andrey Pleskach <[email protected]>
02f5e0f
to
8f536a5
Compare
Added a new issue which is related to action group |
@willyborankin The changes look good to me. I will add my approval once the pending comment is resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @willyborankin. I've opened an issue for discussion around static field. Approving this PR as this a non-blocker and can be addressed in a follow-up PR if needed.
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-4371-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e455aa1c3e02b322531a16b940e1f70d23ea0092
# Push it to GitHub
git push --set-upstream origin backport/backport-4371-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.x Then, create a pull request where the |
…#4166 (opensearch-project#4371) Signed-off-by: Andrey Pleskach <[email protected]> (cherry picked from commit e455aa1)
Description
Changes:
ActionGroupsApiTest
intoActionGroupsRestApiIntegrationTest
LegacySecurityInfoActionTests
andSecurityInfoActionTest
since test cases were moved intoDefaultApiAvailabilityIntegrationTest
Issues Resolved
#4166 - only for action groups
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.