Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made sensitive header log statement more clear #4367

Merged
merged 1 commit into from
May 28, 2024

Conversation

cthtrifork
Copy link
Contributor

Description

This is a bugfix of a logging statement that has caused a lot of confusion for our customers.

Issues Resolved

Testing

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.45%. Comparing base (f71d2e6) to head (2df756e).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4367      +/-   ##
==========================================
+ Coverage   65.43%   65.45%   +0.01%     
==========================================
  Files         310      310              
  Lines       21992    21992              
  Branches     3554     3554              
==========================================
+ Hits        14391    14394       +3     
+ Misses       5830     5828       -2     
+ Partials     1771     1770       -1     
Files Coverage Δ
...ensearch/security/auditlog/config/AuditConfig.java 97.12% <100.00%> (ø)

... and 2 files with indirect coverage changes

@cwperks cwperks added the backport 2.x backport to 2.x branch label May 28, 2024
@willyborankin willyborankin merged commit a2bb6e9 into opensearch-project:main May 28, 2024
83 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 28, 2024
Signed-off-by: Casper Thygesen <[email protected]>
(cherry picked from commit a2bb6e9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@peternied
Copy link
Member

@cthtrifork Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants