Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] REST API tests refactoring (#4252 and #4255) #4328

Merged

Conversation

willyborankin
Copy link
Collaborator

@willyborankin willyborankin commented May 7, 2024

Manual backport #4252 #4255 to 2.x.
The failure reason for both was deleted tests.

Signed-off-by: Andrey Pleskach <[email protected]>
(cherry picked from commit faac5e3)
Signed-off-by: Andrey Pleskach <[email protected]>
(cherry picked from commit f130915)
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.94%. Comparing base (4ac861e) to head (512a112).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x    #4328      +/-   ##
==========================================
- Coverage   66.05%   65.94%   -0.11%     
==========================================
  Files         301      301              
  Lines       21581    21581              
  Branches     3513     3513              
==========================================
- Hits        14255    14232      -23     
- Misses       5569     5588      +19     
- Partials     1757     1761       +4     
Files Coverage Δ
...arch/security/ssl/OpenSearchSecuritySSLPlugin.java 86.30% <ø> (ø)

... and 10 files with indirect coverage changes

@cwperks cwperks merged commit 10f1515 into opensearch-project:2.x May 8, 2024
77 of 78 checks passed
@cwperks cwperks changed the title [Backport 2.x] REST API tests refatcoring (#4252 and #4255) [Backport 2.x] REST API tests refactoring (#4252 and #4255) May 8, 2024
@willyborankin willyborankin deleted the backport-4252-4255-to-2.x branch June 14, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants