[FEATURE] Improve built-in secure transports support #4179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reta
requested review from
cliu123,
cwperks,
DarshitChanpura,
peternied,
RyanL1997,
stephen-crawford and
willyborankin
as code owners
|
Depends on opensearch-project/OpenSearch#12907 |
8 tasks
stephen-crawford
previously approved these changes
Mar 27, 2024
src/main/java/org/opensearch/security/ssl/OpenSearchSecuritySSLPlugin.java
Show resolved
Hide resolved
src/test/java/org/opensearch/security/ssl/OpenSearchSecuritySSLPluginTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
|
The BWC / plugins check fail, we need distributions being published |
peternied
reviewed
Mar 28, 2024
src/main/java/org/opensearch/security/ssl/OpenSearchSecureSettingsFactory.java
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4179 +/- ##
==========================================
- Coverage 66.21% 66.19% -0.02%
==========================================
Files 302 301 -1
Lines 21701 21709 +8
Branches 3501 3505 +4
==========================================
+ Hits 14369 14371 +2
- Misses 5579 5581 +2
- Partials 1753 1757 +4
|
|
@scrawfor99 may I ask you please to reapprove (new tests were pushed), thank you! |
peternied
approved these changes
Mar 28, 2024
|
The BWC tests are failing because the change is breaking (on experimental API) and for a clean build, we would need #4187 first |
willyborankin
approved these changes
Mar 28, 2024
dlin2028
pushed a commit
to dlin2028/security
that referenced
this pull request
May 1, 2024
…ect#4179) Signed-off-by: Andriy Redko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Incorporate further improvements from opensearch-project/OpenSearch#12907
Issues Resolved
Part of opensearch-project/OpenSearch#12903
Is this a backport? If so, please add backport PR # and/or commits #
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.