-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract route paths prefixes into constants #4173
Merged
stephen-crawford
merged 1 commit into
opensearch-project:main
from
willyborankin:extract-constant
Mar 27, 2024
Merged
Extract route paths prefixes into constants #4173
stephen-crawford
merged 1 commit into
opensearch-project:main
from
willyborankin:extract-constant
Mar 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willyborankin
force-pushed
the
extract-constant
branch
from
March 26, 2024 17:19
5441fe7
to
e47ee10
Compare
peternied
approved these changes
Mar 26, 2024
willyborankin
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
RyanL1997,
stephen-crawford and
reta
as code owners
March 26, 2024 18:16
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4173 +/- ##
==========================================
+ Coverage 66.22% 66.23% +0.01%
==========================================
Files 302 302
Lines 21698 21701 +3
Branches 3501 3501
==========================================
+ Hits 14369 14374 +5
+ Misses 5577 5575 -2
Partials 1752 1752
|
Extracted route path prefixes into contants: - "/_plugins/_security" - PLUGIN_ROUTE_PREFIX - "/_opendistro/_security" - LEGACY_PLUGIN_ROUTE_PREFIX - "/_plugins/_security/api" - PLUGIN_API_ROUTE_PREFIX - "/_opendistro/_security/api" - LEGACY_PLUGIN_API_ROUTE_PREFIX Signed-off-by: Andrey Pleskach <[email protected]>
willyborankin
force-pushed
the
extract-constant
branch
from
March 27, 2024 17:26
e47ee10
to
e73d1fc
Compare
stephen-crawford
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
dlin2028
pushed a commit
to dlin2028/security
that referenced
this pull request
May 1, 2024
Signed-off-by: Andrey Pleskach <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 21, 2024
Signed-off-by: Andrey Pleskach <[email protected]> (cherry picked from commit aa56d26) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted route path prefixes into contants:
/_plugins/_security
-PLUGIN_ROUTE_PREFIX
/_opendistro/_security
-LEGACY_PLUGIN_ROUTE_PREFIX
/_plugins/_security/api
-PLUGIN_API_ROUTE_PREFIX
/_opendistro/_security/api
-LEGACY_PLUGIN_API_ROUTE_PREFIX
Same part of #4153 for simplicity of the final PR.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.