Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract route paths prefixes into constants #4173

Merged

Conversation

willyborankin
Copy link
Collaborator

Extracted route path prefixes into contants:

  • /_plugins/_security - PLUGIN_ROUTE_PREFIX
  • /_opendistro/_security - LEGACY_PLUGIN_ROUTE_PREFIX
  • /_plugins/_security/api - PLUGIN_API_ROUTE_PREFIX
  • /_opendistro/_security/api - LEGACY_PLUGIN_API_ROUTE_PREFIX

Same part of #4153 for simplicity of the final PR.

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 66.23%. Comparing base (b0d26dd) to head (e73d1fc).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4173      +/-   ##
==========================================
+ Coverage   66.22%   66.23%   +0.01%     
==========================================
  Files         302      302              
  Lines       21698    21701       +3     
  Branches     3501     3501              
==========================================
+ Hits        14369    14374       +5     
+ Misses       5577     5575       -2     
  Partials     1752     1752              
Files Coverage Δ
...y/action/onbehalf/CreateOnBehalfOfTokenAction.java 12.90% <ø> (ø)
...g/opensearch/security/dlic/rest/support/Utils.java 63.41% <100.00%> (ø)
...opensearch/security/rest/DashboardsInfoAction.java 79.54% <100.00%> (+0.47%) ⬆️
...opensearch/security/rest/SecurityHealthAction.java 100.00% <ø> (ø)
...g/opensearch/security/rest/SecurityInfoAction.java 51.85% <ø> (ø)
...org/opensearch/security/rest/TenantInfoAction.java 86.95% <ø> (ø)
...dlic/auth/http/saml/AuthTokenProcessorHandler.java 50.28% <50.00%> (-0.01%) ⬇️

... and 4 files with indirect coverage changes

Extracted route path prefixes into contants:

 - "/_plugins/_security" - PLUGIN_ROUTE_PREFIX
 - "/_opendistro/_security" - LEGACY_PLUGIN_ROUTE_PREFIX
 - "/_plugins/_security/api" - PLUGIN_API_ROUTE_PREFIX
 - "/_opendistro/_security/api" - LEGACY_PLUGIN_API_ROUTE_PREFIX

Signed-off-by: Andrey Pleskach <[email protected]>
Copy link
Contributor

@stephen-crawford stephen-crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@stephen-crawford stephen-crawford merged commit aa56d26 into opensearch-project:main Mar 27, 2024
82 checks passed
dlin2028 pushed a commit to dlin2028/security that referenced this pull request May 1, 2024
@willyborankin willyborankin added the backport 2.x backport to 2.x branch label May 21, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 21, 2024
Signed-off-by: Andrey Pleskach <[email protected]>
(cherry picked from commit aa56d26)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@willyborankin willyborankin deleted the extract-constant branch June 14, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants