Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump com.google.errorprone:error_prone_annotations from 2.25.0 to 2.26.1 #4126

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 18, 2024

Bumps com.google.errorprone:error_prone_annotations from 2.25.0 to 2.26.1.

Release notes

Sourced from com.google.errorprone:error_prone_annotations's releases.

Error Prone 2.26.1

This release contains all of the changes in 2.26.0, plus a bug fix to the module name of the annotations artifact com.google.errorprone.annotations (google/error-prone@9d99ee7)

Starting in 2.26.x, the 'annotations' artifact now includes a module-info.java for Java Platform Module System support, thanks to @​sgammon in #4311.


Compatibility note:

Now that the annotations artifact explicit declares a module instead of relying on Automatic-Module-Name, JDK 17 and newer perform stricter module encapsulation checks. Modularized libraries depending on Error Prone annotations 2.26.x and newer may see errors like:

error: package com.google.errorprone.annotations is not visible
import com.google.errorprone.annotations.CheckReturnValue;
                            ^
  (package com.google.errorprone.annotations is declared in module com.google.errorprone.annotations, but module ... does not read it)

The fix is to add requires static to the module declaration of modularized libraries that depend on Error Prone annotations:

 module your.module {
...
+  requires static com.google.errorprone.annotations;
 }

Full Changelog: google/error-prone@v2.26.0...v2.26.1

Error Prone 2.26.0

Warning: This release contains a bug, please use 2.26.1 or newer instead.

Changes:

  • The 'annotations' artifact now includes a module-info.java for Java Platform Module System support, thanks to @​sgammon in #4311.
  • Disabled checks passed to -XepPatchChecks are now ignored, instead of causing a crash. Thanks to @​oxkitsune in #4028.

New checks:

  • SystemConsoleNull: Null-checking System.console() is not a reliable way to detect if the console is connected to a terminal.
  • EnumOrdinal: Discourage uses of Enum.ordinal()

Closed issues: #2649, #3908, #4028, #4311, #4314

Full Changelog: google/error-prone@v2.25.0...v2.26.0

Commits
  • b380572 Release Error Prone 2.26.1
  • 9d99ee7 fix: module name → com.google.errorprone.annotations
  • ea5ef6d Add the 'compile' goal for 'compile-java9'
  • 0e95364 feat: add jpms definition for annotations
  • 9da2d55 Ignore disabled checks passed to -XepPatchChecks
  • 3292632 Increase year range on Date usages.
  • ad513d5 Recommend using var for var unused = ...; and `var thrown = assertThrows(...
  • af37d35 ImpossibleNullComparison: emit empty fixes.
  • 297019c Fix some mistakes in the EnumOrdinal examples
  • f3dbb09 Move the EnumOrdinal.md doc to the right place (it got overwritten by automat...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [com.google.errorprone:error_prone_annotations](https://github.com/google/error-prone) from 2.25.0 to 2.26.1.
- [Release notes](https://github.com/google/error-prone/releases)
- [Commits](google/error-prone@v2.25.0...v2.26.1)

---
updated-dependencies:
- dependency-name: com.google.errorprone:error_prone_annotations
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from cliu123 as a code owner March 18, 2024 06:49
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Mar 18, 2024
@willyborankin willyborankin mentioned this pull request Mar 18, 2024
1 task
@willyborankin willyborankin added the backport 2.x backport to 2.x branch label Mar 19, 2024
@willyborankin willyborankin merged commit 582d2cd into main Mar 19, 2024
92 checks passed
@willyborankin willyborankin deleted the dependabot/gradle/com.google.errorprone-error_prone_annotations-2.26.1 branch March 19, 2024 13:08
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/security/backport-2.x
# Create a new branch
git switch --create backport/backport-4126-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 582d2cddbe3c23640370698647752b39ff58eed0
# Push it to GitHub
git push --set-upstream origin backport/backport-4126-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-4126-to-2.x.

willyborankin added a commit to willyborankin/security that referenced this pull request Mar 19, 2024
DarshitChanpura pushed a commit that referenced this pull request Mar 19, 2024
dlin2028 pushed a commit to dlin2028/security that referenced this pull request May 1, 2024
…6.1 (opensearch-project#4126)

Bumps
[com.google.errorprone:error_prone_annotations](https://github.com/google/error-prone)
from 2.25.0 to 2.26.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/google/error-prone/releases">com.google.errorprone:error_prone_annotations's
releases</a>.</em></p>
<blockquote>
<h2>Error Prone 2.26.1</h2>
<p>This release contains all of the changes in <a
href="https://github.com/google/error-prone/releases/tag/v2.26.0">2.26.0</a>,
plus a bug fix to the module name of the annotations artifact
<code>com.google.errorprone.annotations</code> (<a
href="https://github.com/google/error-prone/commit/9d99ee76f2ca8568b69150f5df7fe845c8545d16">https://github.com/google/error-prone/commit/9d99ee76f2ca8568b69150f5df7fe845c8545d16</a>)</p>
<p>Starting in <code>2.26.x</code>, the 'annotations' artifact now
includes a <code>module-info.java</code> for Java Platform Module System
support, thanks to <a
href="https://github.com/sgammon"><code>@​sgammon</code></a> in <a
href="https://redirect.github.com/google/error-prone/issues/4311">#4311</a>.</p>
<hr />
<p><strong>Compatibility note:</strong></p>
<p>Now that the annotations artifact explicit declares a module instead
of relying on <code>Automatic-Module-Name</code>, JDK 17 and newer
perform stricter module encapsulation checks. Modularized libraries
depending on Error Prone annotations <code>2.26.x</code> and newer may
see errors like:</p>
<pre><code>error: package com.google.errorprone.annotations is not
visible
import com.google.errorprone.annotations.CheckReturnValue;
                            ^
(package com.google.errorprone.annotations is declared in module
com.google.errorprone.annotations, but module ... does not read it)
</code></pre>
<p>The fix is to add <code>requires static</code> to the module
declaration of modularized libraries that depend on Error Prone
annotations:</p>
<pre lang="diff"><code> module your.module {
...
+  requires static com.google.errorprone.annotations;
 }
</code></pre>
<hr />
<p>Full Changelog: <a
href="https://github.com/google/error-prone/compare/v2.26.0...v2.26.1">https://github.com/google/error-prone/compare/v2.26.0...v2.26.1</a></p>
<h2>Error Prone 2.26.0</h2>
<p><strong>Warning: This release contains a bug, please use <a
href="https://github.com/google/error-prone/releases/tag/v2.26.1">2.26.1</a>
or newer instead.</strong></p>
<p>Changes:</p>
<ul>
<li>The 'annotations' artifact now includes a
<code>module-info.java</code> for Java Platform Module System support,
thanks to <a
href="https://github.com/sgammon"><code>@​sgammon</code></a> in <a
href="https://redirect.github.com/google/error-prone/issues/4311">#4311</a>.</li>
<li>Disabled checks passed to <code>-XepPatchChecks</code> are now
ignored, instead of causing a crash. Thanks to <a
href="https://github.com/oxkitsune"><code>@​oxkitsune</code></a> in <a
href="https://redirect.github.com/google/error-prone/issues/4028">#4028</a>.</li>
</ul>
<p>New checks:</p>
<ul>
<li><a
href="https://errorprone.info/bugpattern/SystemConsoleNull"><code>SystemConsoleNull</code></a>:
Null-checking <code>System.console()</code> is not a reliable way to
detect if the console is connected to a terminal.</li>
<li><a
href="https://errorprone.info/bugpattern/EnumOrdinal"><code>EnumOrdinal</code></a>:
Discourage uses of <code>Enum.ordinal()</code></li>
</ul>
<p>Closed issues: <a
href="https://redirect.github.com/google/error-prone/issues/2649">#2649</a>,
<a
href="https://redirect.github.com/google/error-prone/issues/3908">#3908</a>,
<a
href="https://redirect.github.com/google/error-prone/issues/4028">#4028</a>,
<a
href="https://redirect.github.com/google/error-prone/issues/4311">#4311</a>,
<a
href="https://redirect.github.com/google/error-prone/issues/4314">#4314</a></p>
<p>Full Changelog: <a
href="https://github.com/google/error-prone/compare/v2.25.0...v2.26.0">https://github.com/google/error-prone/compare/v2.25.0...v2.26.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/google/error-prone/commit/b38057250a8a035d6b3856098145aeab1df1149f"><code>b380572</code></a>
Release Error Prone 2.26.1</li>
<li><a
href="https://github.com/google/error-prone/commit/9d99ee76f2ca8568b69150f5df7fe845c8545d16"><code>9d99ee7</code></a>
fix: module name → <code>com.google.errorprone.annotations</code></li>
<li><a
href="https://github.com/google/error-prone/commit/ea5ef6dd29022683eced044a2b0b3fa91d8b3200"><code>ea5ef6d</code></a>
Add the 'compile' goal for 'compile-java9'</li>
<li><a
href="https://github.com/google/error-prone/commit/0e9536471b6b8e7e03d29584eceb8a0e0f3240d7"><code>0e95364</code></a>
feat: add jpms definition for <code>annotations</code></li>
<li><a
href="https://github.com/google/error-prone/commit/9da2d5580e3939f97ef2e91278b330a56b5ed1fe"><code>9da2d55</code></a>
Ignore disabled checks passed to <code>-XepPatchChecks</code></li>
<li><a
href="https://github.com/google/error-prone/commit/3292632ee5f2776b57171bedef6bdb1c4c222345"><code>3292632</code></a>
Increase year range on <code>Date</code> usages.</li>
<li><a
href="https://github.com/google/error-prone/commit/ad513d5a82dc803dcc5179ffcdf7073d43430623"><code>ad513d5</code></a>
Recommend using <code>var</code> for <code>var unused = ...;</code> and
`var thrown = assertThrows(...</li>
<li><a
href="https://github.com/google/error-prone/commit/af37d35d208d37e9658038127d35afdd41325da4"><code>af37d35</code></a>
ImpossibleNullComparison: emit empty fixes.</li>
<li><a
href="https://github.com/google/error-prone/commit/297019c6706c8c27a58717f0a4269abf92af8de4"><code>297019c</code></a>
Fix some mistakes in the EnumOrdinal examples</li>
<li><a
href="https://github.com/google/error-prone/commit/f3dbb094f5105fa1f5a17c69d50a6663b414a6d5"><code>f3dbb09</code></a>
Move the EnumOrdinal.md doc to the right place (it got overwritten by
automat...</li>
<li>Additional commits viewable in <a
href="https://github.com/google/error-prone/compare/v2.25.0...v2.26.1">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.google.errorprone:error_prone_annotations&package-manager=gradle&previous-version=2.25.0&new-version=2.26.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants