-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional ignore_headers audit configuration setting #3885
Add additional ignore_headers audit configuration setting #3885
Conversation
Signed-off-by: Stephen Crawford <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I left one small suggestion around naming the method on the filter.
src/main/java/org/opensearch/security/auditlog/impl/AuditMessage.java
Outdated
Show resolved
Hide resolved
…ge.java Co-authored-by: Craig Perkins <[email protected]> Signed-off-by: Stephen Crawford <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left few nits
src/main/java/org/opensearch/security/OpenSearchSecurityPlugin.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/security/compliance/ComplianceConfig.java
Outdated
Show resolved
Hide resolved
There is a compilation error:
|
Signed-off-by: Stephen Crawford <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3885 +/- ##
==========================================
+ Coverage 65.18% 65.21% +0.02%
==========================================
Files 298 298
Lines 21195 21210 +15
Branches 3456 3457 +1
==========================================
+ Hits 13817 13832 +15
Misses 5664 5664
Partials 1714 1714
|
src/main/java/org/opensearch/security/compliance/ComplianceConfig.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/security/auditlog/config/AuditConfigSerializeTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Stephen Crawford <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> Co-authored-by: Craig Perkins <[email protected]> (cherry picked from commit 03fd79f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@scrawfor99 Do you have a link to the documentation update? |
…ing (#3926) Backport 03fd79f from #3885. Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Craig Perkins <[email protected]>
…-project#3885) Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> Co-authored-by: Craig Perkins <[email protected]>
Description
This change adds a new setting to the audit.yml configuration allowing users to specify REST headers they wish to be ignored from audit logging.
Issues Resolved
Testing
Added a couple new test cases to check the setting
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.