Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Change the saml acs endpoint to support _plugin #3246

Closed

Conversation

RyanL1997
Copy link
Collaborator

Description

[Describe what this change achieves]

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
  • Why these changes are required?
  • What is the old behavior before changes and new behavior after changes?

Issues Resolved

[List any issues this PR will resolve]

Is this a backport? If so, please add backport PR # and/or commits #

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

Merging #3246 (74bb89e) into main (d7eabcf) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3246      +/-   ##
============================================
- Coverage     62.51%   62.49%   -0.03%     
+ Complexity     3403     3400       -3     
============================================
  Files           259      259              
  Lines         20055    20055              
  Branches       3370     3370              
============================================
- Hits          12538    12533       -5     
- Misses         5866     5872       +6     
+ Partials       1651     1650       -1     
Files Changed Coverage Δ
...zon/dlic/auth/http/saml/Saml2SettingsProvider.java 60.18% <50.00%> (ø)

... and 2 files with indirect coverage changes

@RyanL1997
Copy link
Collaborator Author

Closing this according to #3271

@RyanL1997 RyanL1997 closed this Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant