Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import for TransportAddress after core refactor #9073 #3091

Merged

Conversation

willyborankin
Copy link
Collaborator

Description

This PR fixed TransportAddress imports after core refactor in #9073

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #3091 (5b4bfea) into main (5384272) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #3091      +/-   ##
============================================
- Coverage     62.42%   62.39%   -0.04%     
+ Complexity     3352     3350       -2     
============================================
  Files           254      254              
  Lines         19741    19741              
  Branches       3334     3334              
============================================
- Hits          12324    12318       -6     
- Misses         5787     5790       +3     
- Partials       1630     1633       +3     
Files Changed Coverage Δ
.../opensearch/security/OpenSearchSecurityPlugin.java 84.34% <ø> (ø)
...earch/security/auditlog/impl/AbstractAuditLog.java 76.48% <ø> (ø)
...pensearch/security/auditlog/impl/AuditMessage.java 74.00% <ø> (ø)
...search/security/auditlog/impl/RequestResolver.java 67.75% <ø> (ø)
.../org/opensearch/security/auth/BackendRegistry.java 60.13% <ø> (ø)
...ava/org/opensearch/security/auth/UserInjector.java 90.00% <ø> (ø)
...ty/configuration/SecurityIndexSearcherWrapper.java 88.88% <ø> (ø)
...earch/security/dlic/rest/api/AccountApiAction.java 85.13% <ø> (ø)
.../security/dlic/rest/api/PermissionsInfoAction.java 19.56% <ø> (ø)
...dlic/rest/api/RestApiAdminPrivilegesEvaluator.java 71.42% <ø> (ø)
... and 11 more

... and 3 files with indirect coverage changes

@peternied
Copy link
Member

:( I am concerned that there is no valid snapshot with the transport changes, 🤞 soon we get another update?

@willyborankin
Copy link
Collaborator Author

:( I am concerned that there is no valid snapshot with the transport changes, 🤞 soon we get another update?

no looks like only BWC tests which is expected.

@cwperks
Copy link
Member

cwperks commented Aug 3, 2023

The failures last night were due to stale minimum distribution, but now it looks like this may need to be backported to 2.x before merged into main to fix the bwc checks.

Fixed `TransportAddress` imports after core refactor inhttps://github.com/opensearch-project/OpenSearch/pull/9073

Signed-off-by: Andrey Pleskach <[email protected]>
@willyborankin willyborankin force-pushed the fix-transport-address branch from 56172cd to 5b4bfea Compare August 3, 2023 14:58
@cwperks cwperks merged commit 3d78135 into opensearch-project:main Aug 3, 2023
@cwperks
Copy link
Member

cwperks commented Aug 3, 2023

Thank you @willyborankin !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants