resolving dependency conflict for org.apache.httpcomponents:httpclient #2951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parasjain1
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
Signed-off-by: Paras Jain <[email protected]>
parasjain1
force-pushed
the
apache-dependency-fix
branch
from
7c55589 to
9816f7d
Compare
Codecov Report
@@ Coverage Diff @@
## main #2951 +/- ##
============================================
- Coverage 62.30% 62.16% -0.14%
+ Complexity 3337 3328 -9
============================================
Files 266 266
Lines 19650 19650
Branches 3329 3329
============================================
- Hits 12242 12215 -27
- Misses 5782 5799 +17
- Partials 1626 1636 +10 |
|
@parasjain1 I just opened a separate PR against the 2.x branch. I think the issue is that 2.x is explicitly referring to 4.5.13 and should instead take the version of httpclient from core's buildSrc/version.properties |
Thanks @cwperks , that would be the right fix |
|
@parasjain1 I am closing this PR. There was a PR against the 2.x branch that was merged to fix the bwc test issue: #2953 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolving dependency conflict for org.apache.httpcomponents:httpclient
Issues Resolved
#2950
Is this a backport? If so, please add backport PR # and/or commits #
N/A
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.